Вход: отклонять POST /auth/sessions с телом (400)
Skeleton contracts / contracts (pull_request) Canceled after 0s
Skeleton contracts / contracts (pull_request) Canceled after 0s
Контракт задаёт вход без тела; раньше лишний JSON игнорировался, и запрос с правильным Basic создавал сессию. Добавлен отрицательный тест.
This commit is contained in:
@@ -26,6 +26,12 @@ basic_scheme = RawBasicHeader(scheme_name="basicAuth", auto_error=False)
|
||||
bearer_scheme = RawBearerHeader(scheme_name="bearerAuth", auto_error=False)
|
||||
|
||||
|
||||
async def require_empty_body(request: Request) -> None:
|
||||
# Контракт задаёт вход без тела: лишний JSON не игнорируем молча, а отклоняем.
|
||||
if await request.body():
|
||||
raise HTTPException(status_code=400, detail="Тело запроса не допускается")
|
||||
|
||||
|
||||
def unauthorized() -> HTTPException:
|
||||
return HTTPException(status_code=401, detail="Нужен действительный Bearer-токен", headers=BEARER_CHALLENGE)
|
||||
|
||||
|
||||
@@ -4,7 +4,7 @@ import binascii
|
||||
from fastapi import APIRouter, Depends, HTTPException, Response, Security
|
||||
from sqlalchemy.orm import Session
|
||||
|
||||
from api.dependencies import basic_scheme, get_current_session
|
||||
from api.dependencies import basic_scheme, get_current_session, require_empty_body
|
||||
from core.config import settings
|
||||
from core.db import get_db
|
||||
from core.logger import logger
|
||||
@@ -43,7 +43,8 @@ def parse_basic(authorization: str | None) -> tuple[str, str]:
|
||||
return username, password
|
||||
|
||||
|
||||
@roter.post("/sessions", status_code=201, response_model=SessionResponse)
|
||||
# Тело проверяется до пароля: зависимости маршрута выполняются раньше параметров.
|
||||
@roter.post("/sessions", status_code=201, response_model=SessionResponse, dependencies=[Depends(require_empty_body)])
|
||||
def create_session_api(authorization: str | None = Security(basic_scheme), db: Session = Depends(get_db)):
|
||||
username, password = parse_basic(authorization)
|
||||
|
||||
|
||||
@@ -1,9 +1,11 @@
|
||||
import time
|
||||
|
||||
import jwt
|
||||
from sqlalchemy import text
|
||||
|
||||
from conftest import PASSWORD, assert_error, basic, bearer, login
|
||||
from core.config import settings
|
||||
from core.db import engine
|
||||
|
||||
|
||||
def assert_challenge(response, scheme):
|
||||
@@ -44,6 +46,18 @@ def test_malformed_basic_returns_401(client):
|
||||
assert_challenge(response, "Basic")
|
||||
|
||||
|
||||
def test_login_with_body_returns_400_and_creates_no_session(client, alice):
|
||||
with engine.connect() as connection:
|
||||
before = connection.scalar(text("SELECT count(*) FROM sessions"))
|
||||
for kwargs in ({"json": {"unexpected": True}}, {"json": {}}, {"content": b"x"}):
|
||||
response = client.post("/api/v1/auth/sessions", headers=basic("alice", PASSWORD), **kwargs)
|
||||
assert_error(response, 400, "invalid_request")
|
||||
with engine.connect() as connection:
|
||||
assert connection.scalar(text("SELECT count(*) FROM sessions")) == before
|
||||
# Без тела вход по-прежнему работает.
|
||||
assert login(client, "alice")["user"]["id"] == alice["id"]
|
||||
|
||||
|
||||
def test_password_with_colon_and_unicode(client):
|
||||
password = "пароль:с:двоеточиями 👋"
|
||||
client.post("/api/v1/users", json={"username": "colon", "display_name": "C", "password": password})
|
||||
|
||||
Reference in New Issue
Block a user