forked from mtusi2026/mtusi2026lab2
Check the request shape before chat access on posting a message
FastAPI rejects a missing Idempotency-Key, extra fields and wrong types with 400 before the handler runs, so an outsider gets the same 400 for an existing and a missing chat; only a bad text, checked by the domain, makes the handler look up membership and answer 404. The new test pins that order so it is a recorded rule rather than an accident. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V1d3RLHNBBMA6UqBLLJv27
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
be17939ddb
commit
a761b718b8
@@ -1,6 +1,6 @@
|
||||
## 1. Требования и код
|
||||
|
||||
- [ ] 1.1 Тест порядка проверок `POST …/messages` для постороннего (`test_request_shape_is_checked_before_access`)
|
||||
- [x] 1.1 Тест порядка проверок `POST …/messages` для постороннего (`test_request_shape_is_checked_before_access`)
|
||||
- [ ] 1.2 Убрать `# type: ignore` из `shared/entrypoints/errors.py`
|
||||
- [ ] 1.3 `openspec/config.yaml`: `gunicorn_conf.py` в карте модулей
|
||||
- [ ] 1.4 Проверка группы: `make lint`, `make student-test`, `make check`
|
||||
|
||||
@@ -82,3 +82,19 @@ async def test_403_is_never_used(client: AsyncClient) -> None:
|
||||
]
|
||||
for path in paths:
|
||||
assert (await client.get(path, headers=actor(eve))).status_code != 403
|
||||
|
||||
|
||||
async def test_request_shape_is_checked_before_access(client: AsyncClient) -> None:
|
||||
alice = await register(client, "alice")
|
||||
eve = await register(client, "eve")
|
||||
chat = await make_chat(client, alice)
|
||||
for chat_id in (chat["id"], uuid4()):
|
||||
path = f"/api/v1/chats/{chat_id}/messages"
|
||||
unkeyed = await client.post(path, json={"text": "чужое"}, headers=actor(eve))
|
||||
extra = await client.post(path, json={"text": "x", "a": 1}, headers=keyed(eve))
|
||||
assert unkeyed.status_code == extra.status_code == 400
|
||||
assert unkeyed.json()["error"]["code"] == extra.json()["error"]["code"] == "invalid_request"
|
||||
blank = await client.post(
|
||||
f"/api/v1/chats/{chat['id']}/messages", json={"text": " "}, headers=keyed(eve)
|
||||
)
|
||||
assert blank.status_code == 404
|
||||
|
||||
Reference in New Issue
Block a user