Files
mtusi2026lab3/student-tests/api/test_wire_format.py
T
ArtyomandClaude Opus 5.5 7bf28fc6ed Make message posts idempotent with Idempotency-Key
POST /api/v1/chats/{chat_id}/messages now requires the header, checked
at the HTTP boundary (1-128 of [A-Za-z0-9._:-], else 400). The handler
keeps the lab 2 order under the chat row lock: membership, then text,
then the receipt for (chat, sender, key) younger than
IDEMPOTENCY_TTL_SECONDS. A receipt with the same fingerprint replays
the stored message, a different one is 409 conflict; without a
receipt one statement inserts the message, the key row and the chat
mark, so both commit or neither does. Concurrent retries wait on the
same row lock and then read the committed receipt. The fingerprint is
SHA-256 of the canonical JSON of the parsed body, so layout does not
matter, and only 201 answers are ever stored.

A lock timeout now counts as a dependency failure and answers 503
instead of 500, so a retry with the same key is safe.

Own tests cover replay, a different layout of the same JSON, conflict,
missing and malformed keys, rejected attempts that leave the key free,
scope by user and chat, revalidation after logout and for outsiders,
expiry, and eight concurrent retries through two app instances
sharing one PostgreSQL. Every earlier message post sends a fresh key.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-28 11:36:15 +03:00

69 lines
2.6 KiB
Python

import json
import re
from datetime import UTC, datetime
from typing import Any
import pytest
from httpx import Response
from conftest import bearer, login, new_user, running_app
from messenger.shared.infrastructure.clock import MonotonicUtcClock
RFC3339_UTC = re.compile(r"\A\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(\.\d{1,6})?Z\Z")
MOMENTS = [
datetime(2026, 10, 12, 8, 49, 2, tzinfo=UTC),
datetime(2026, 10, 12, 8, 49, 2, 120, tzinfo=UTC),
]
def assert_wire(response: Response, expected: dict[str, Any]) -> None:
assert (
response.content == json.dumps(expected, ensure_ascii=False, separators=(",", ":")).encode()
)
@pytest.mark.parametrize("moment", MOMENTS, ids=["whole-second", "microseconds"])
async def test_created_at_is_rfc3339_utc(monkeypatch: pytest.MonkeyPatch, moment: datetime) -> None:
monkeypatch.setattr(MonotonicUtcClock, "now", lambda _self: moment)
stamp = moment.isoformat().replace("+00:00", "Z")
assert RFC3339_UTC.match(stamp)
async with running_app() as http:
body = new_user("wire")
response = await http.post("/api/v1/users", json=body)
user_id = response.json()["id"]
user = {
"id": user_id,
"username": body["username"],
"display_name": body["display_name"],
"created_at": stamp,
}
assert_wire(response, user)
session = await login(http, body["username"])
headers = bearer(session["token"])
assert session["user"] == user
assert_wire(await http.get("/api/v1/users/me", headers=headers), user)
response = await http.post(
"/api/v1/chats", json={"title": "Чат", "member_ids": [user_id]}, headers=headers
)
chat_id = response.json()["id"]
chat = {"id": chat_id, "title": "Чат", "member_ids": [user_id], "created_at": stamp}
assert_wire(response, chat)
assert_wire(await http.get(f"/api/v1/chats/{chat_id}", headers=headers), chat)
listed = await http.get("/api/v1/chats", headers=headers)
assert_wire(listed, {"items": [chat], "next_cursor": None})
path = f"/api/v1/chats/{chat_id}/messages"
sent = {**headers, "Idempotency-Key": "wire-1"}
response = await http.post(path, json={"text": "привет"}, headers=sent)
message = {
"id": response.json()["id"],
"chat_id": chat_id,
"sender_id": user_id,
"text": "привет",
"created_at": stamp,
}
assert_wire(response, message)
history = await http.get(path, headers=headers)
assert_wire(history, {"items": [message], "next_cursor": None})