feat(service):lab4 sweep orphan objects in S3
This commit is contained in:
@@ -72,8 +72,10 @@ func (r *Reconciler) tick(ctx context.Context) {
|
||||
defer release()
|
||||
|
||||
pendingDeleted := r.sweepPending(ctx)
|
||||
if pendingDeleted > 0 {
|
||||
log.Printf("reconciler: sweep done pending=%d", pendingDeleted)
|
||||
orphansDeleted := r.sweepOrphans(ctx)
|
||||
|
||||
if pendingDeleted > 0 || orphansDeleted > 0 {
|
||||
log.Printf("reconciler: sweep done pending=%d orphans=%d", pendingDeleted, orphansDeleted)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -126,3 +128,49 @@ func (r *Reconciler) sweepPending(ctx context.Context) int {
|
||||
}
|
||||
return deleted
|
||||
}
|
||||
|
||||
func (r *Reconciler) sweepOrphans(ctx context.Context) int {
|
||||
objects, err := r.storage.List(ctx, "chats/")
|
||||
if err != nil {
|
||||
log.Printf("reconciler: list objects: %v", err)
|
||||
return 0
|
||||
}
|
||||
if len(objects) == 0 {
|
||||
return 0
|
||||
}
|
||||
|
||||
cutoff := time.Now().UTC().Add(-r.gracePeriod)
|
||||
keys := make([]string, 0, len(objects))
|
||||
for _, o := range objects {
|
||||
if o.LastModified.Before(cutoff) {
|
||||
keys = append(keys, o.Key)
|
||||
}
|
||||
}
|
||||
if len(keys) == 0 {
|
||||
return 0
|
||||
}
|
||||
|
||||
existing, err := r.attachments.ExistingKeys(ctx, keys)
|
||||
if err != nil {
|
||||
log.Printf("reconciler: existing keys: %v", err)
|
||||
return 0
|
||||
}
|
||||
|
||||
inDB := make(map[string]struct{}, len(existing))
|
||||
for _, k := range existing {
|
||||
inDB[k] = struct{}{}
|
||||
}
|
||||
|
||||
deleted := 0
|
||||
for _, k := range keys {
|
||||
if _, ok := inDB[k]; ok {
|
||||
continue
|
||||
}
|
||||
if err := r.storage.Delete(ctx, k); err != nil {
|
||||
log.Printf("reconciler: delete orphan %s: %v", k, err)
|
||||
continue
|
||||
}
|
||||
deleted++
|
||||
}
|
||||
return deleted
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user