forked from mtusi2026/mtusi2026lab4
- python -m messenger.reconcile: merge-join листинга S3 и attachments по object_key; dry-run read-only конструктивно (default_transaction_read_only + S3 без записи), --apply: orphan/stale intent удаляются, ready-строки только в карантин (обратимо), перепроверка под FOR UPDATE, предохранитель от массового удаления; - attachment_ids хранится в строке сообщения (история остаётся одним index range scan), message_attachments — для FK и обратного поиска; - семафор полной проверки изображений (IMAGE_VERIFY_CONCURRENCY); - тесты: вложения (56), отказ/пауза S3 и деградированный режим LB, failover загрузки, приватность bucket, FAULT_POINTS после PUT/после COMMIT, janitor, reconciler; - бенчмарки памяти загрузок и стоимости обхода reconciler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
149 lines
5.7 KiB
Python
149 lines
5.7 KiB
Python
"""Unit tests of the image checks (src/messenger/images.py) and the filename rules. No services.
|
||
|
||
The JPEG decoder (djpeg) exists in the API image; locally these tests are skipped without it
|
||
(the same cases run against the stand in test_attachments.py)."""
|
||
from __future__ import annotations
|
||
|
||
import asyncio
|
||
import shutil
|
||
import sys
|
||
import time
|
||
from pathlib import Path
|
||
|
||
import pytest
|
||
|
||
ROOT = Path(__file__).resolve().parents[2]
|
||
sys.path.insert(0, str(ROOT / "src"))
|
||
sys.path.insert(0, str(ROOT / "student-tests"))
|
||
|
||
import imagegen # noqa: E402
|
||
from messenger import images, validation # noqa: E402
|
||
from messenger.errors import InvalidRequest # noqa: E402
|
||
|
||
LIMIT = 40_000_000
|
||
SAMPLE = (ROOT / "tests" / "fixtures" / "sample.png").read_bytes()
|
||
has_djpeg = pytest.mark.skipif(shutil.which("djpeg") is None, reason="djpeg (libjpeg-turbo-progs) not installed")
|
||
|
||
|
||
def status(data: bytes) -> int:
|
||
"""201 if accepted, else the HTTP status of the ImageError (413/415)."""
|
||
try:
|
||
info = images.sniff(data, LIMIT)
|
||
if info is None:
|
||
return 415 # header never completed
|
||
asyncio.run(images.verify(data, info))
|
||
return 201
|
||
except images.ImageError as exc:
|
||
return exc.status
|
||
|
||
|
||
def test_public_fixture_is_accepted():
|
||
assert images.sniff(SAMPLE, LIMIT) == images.ImageInfo("image/png", 320, 200)
|
||
assert status(SAMPLE) == 201
|
||
|
||
|
||
@pytest.mark.parametrize("data", [
|
||
imagegen.png(37, 23, "RGBA"), imagegen.png(33, 17, "P"), imagegen.png(33, 17, "1"),
|
||
imagegen.png(33, 17, "L"), imagegen.png(81, 57, "RGB", noise=True), imagegen.png(1, 1),
|
||
], ids=["rgba", "palette", "1bit", "gray", "noise", "1x1"])
|
||
def test_valid_png_kinds(data):
|
||
assert status(data) == 201
|
||
|
||
|
||
def test_interlaced_png_is_accepted():
|
||
# Pillow cannot write Adam7; build one by hand: 9 x 9 grey, every pass with filter 0.
|
||
from messenger.images import _png_segments
|
||
raw = b"".join(b"\x00" + bytes(stride - 1) for size, stride in _png_segments(9, 9, 8, 0, 1)
|
||
for _ in range(size // stride))
|
||
data = imagegen.PNG_SIGNATURE + imagegen.ihdr(9, 9, 8, 0, 1) + imagegen.chunk(b"IDAT", __import__("zlib").compress(raw)) \
|
||
+ imagegen.chunk(b"IEND", b"")
|
||
assert status(data) == 201
|
||
|
||
|
||
BROKEN_PNG = {
|
||
"first 33 bytes of the fixture": SAMPLE[:33],
|
||
"truncated (no IEND)": SAMPLE[:-12],
|
||
"truncated in IDAT": SAMPLE[:len(SAMPLE) // 2],
|
||
"flipped byte -> CRC error": SAMPLE[:500] + bytes([SAMPLE[500] ^ 0xFF]) + SAMPLE[501:],
|
||
"garbage IDAT with valid CRC": imagegen.png_corrupt_idat(),
|
||
"fewer rows than IHDR": imagegen.png_short_pixels(),
|
||
"bytes after IEND (polyglot)": SAMPLE + b"PK\x03\x04zip",
|
||
"text": b"just text, definitely not an image",
|
||
"gif": b"GIF89a" + bytes(64),
|
||
"two bytes of a signature": b"\x89P",
|
||
}
|
||
|
||
|
||
@pytest.mark.parametrize("name", list(BROKEN_PNG))
|
||
def test_broken_png_is_415(name):
|
||
assert status(BROKEN_PNG[name]) == 415, name
|
||
|
||
|
||
def test_pixel_limit_is_checked_from_the_header():
|
||
with pytest.raises(images.ImageError) as exc:
|
||
images.sniff(imagegen.png_bomb_header()[:33], LIMIT) # 33 bytes are enough
|
||
assert exc.value.status == 413
|
||
exact = imagegen.PNG_SIGNATURE + imagegen.ihdr(8000, 5000) # exactly 40 000 000: allowed
|
||
assert images.sniff(exact, LIMIT).width == 8000
|
||
with pytest.raises(images.ImageError) as exc:
|
||
images.sniff(imagegen.PNG_SIGNATURE + imagegen.ihdr(8001, 5000), LIMIT)
|
||
assert exc.value.status == 413
|
||
with pytest.raises(images.ImageError) as exc:
|
||
images.sniff(imagegen.jpeg_bomb_header(), LIMIT)
|
||
assert exc.value.status == 413
|
||
|
||
|
||
def test_png_verification_is_streaming_and_fast():
|
||
"""40 Mpx RGB = 120 MB of raw pixels: inflated in 1 MiB steps and discarded."""
|
||
big = imagegen.png(8000, 5000, compress_level=9)
|
||
started = time.perf_counter()
|
||
assert status(big) == 201
|
||
assert time.perf_counter() - started < 5
|
||
|
||
|
||
def test_jpeg_header_is_parsed_incrementally():
|
||
data = imagegen.jpeg(320, 200)
|
||
assert images.sniff(data[:4], LIMIT) is None # SOF not arrived yet
|
||
assert images.sniff(data, LIMIT) == images.ImageInfo("image/jpeg", 320, 200)
|
||
|
||
|
||
@has_djpeg
|
||
@pytest.mark.parametrize("data", [imagegen.jpeg(), imagegen.jpeg(640, 480, progressive=True)], ids=["base", "prog"])
|
||
def test_valid_jpeg(data):
|
||
assert status(data) == 201
|
||
|
||
|
||
@has_djpeg
|
||
@pytest.mark.parametrize("name,data", [
|
||
("no scan data after SOS", imagegen.jpeg_without_scan_data()),
|
||
("truncated", imagegen.jpeg(320, 240, noise=True)[:3000]),
|
||
], ids=lambda v: v if isinstance(v, str) else "")
|
||
def test_broken_jpeg_is_415(name, data):
|
||
assert status(data) == 415, name
|
||
|
||
|
||
# ------------------------------------------------------------------ filename
|
||
@pytest.mark.parametrize("name", ["photo.png", "фото отпуска.jpg", "a" * 255, "emoji 👨👩👧.png", " x ", "..."[:2] + "x"])
|
||
def test_good_filenames(name):
|
||
assert validation.filename_param([("filename", name)]) == name
|
||
|
||
|
||
@pytest.mark.parametrize("name", ["", " ", " ", ".", "..", "a/b.png", "a\\b.png", "a\x00b", "c1\x85.png",
|
||
"tab\t.png", "del\x7f.png", "x
y", "photognp.exe", "a" * 256])
|
||
def test_bad_filenames(name):
|
||
with pytest.raises(InvalidRequest):
|
||
validation.filename_param([("filename", name)])
|
||
|
||
|
||
def test_filename_must_be_single_and_present():
|
||
with pytest.raises(InvalidRequest):
|
||
validation.filename_param([])
|
||
with pytest.raises(InvalidRequest):
|
||
validation.filename_param([("filename", "a.png"), ("filename", "b.png")])
|
||
|
||
|
||
def test_query_must_be_valid_utf8():
|
||
assert validation.query_items(b"filename=%D1%84.png") == [("filename", "ф.png")]
|
||
with pytest.raises(InvalidRequest):
|
||
validation.query_items(b"filename=%FF%FE.png")
|