Bring the system changes of lab 3 from 61c0c28..72a1e57 onto the lab 4 code, resolving each conflict by meaning and keeping everything lab 4 added: - a message is posted with one SQL statement under the chat row lock, and the attachment links go into the same statement; a foreign key violation on the attachment link still answers 404 and leaves nothing behind. Text and the attachment list are checked before the write, an outsider gets 404 for both, as before the carry over; - the request pipeline counts the body bytes actually received against the limit of the route, so a chunked body over 1 MiB gets 413 and the upload route keeps its MAX_UPLOAD_BYTES limit; - a request cancelled at shutdown gets 503 unavailable in the contract format, the worker waits a second less than the rest of the shutdown budget, SHUTDOWN_TIMEOUT_SECONDS becomes 6 s and the stop hooks 7 s; - readiness sits behind a Readiness port with the draining flag in shared infrastructure, and the drain window is logged through Logger; - logout revokes through SessionRevocations and withdraws the mark when PostgreSQL rejects the delete; an empty cursor is 400; - EventBus.project is gone, the sweep test subscribes and waits on a queue; domain tests check attachment_list instead of Chat.post; - make up waits for every replica in the balancer, BASE_URL follows the lb port, the image is tagged by the compose project, retry-check and faults-evidence are added, detection runs three times, failover-each and rolling-update record the stand usage, CI checks numeric uids. down also takes the tools and reconcile profiles of lab 4. Track 1 tooling of lab 3 (scaling.py, its samplers, tools/ and the CPU pinning of api, lb, valkey and k6) stays out; stand-usage.sh queries the database size itself instead of the track 1 sampler. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V1d3RLHNBBMA6UqBLLJv27
122 lines
4.8 KiB
Python
122 lines
4.8 KiB
Python
import time
|
|
from uuid import uuid4
|
|
|
|
import asyncpg
|
|
from httpx import AsyncClient
|
|
|
|
from conftest import DATABASE, actor, keyed, make_chat, register
|
|
|
|
|
|
async def test_outsider_gets_404_on_chat(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
bob = await register(client, "bob")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice, bob)
|
|
response = await client.get(f"/api/v1/chats/{chat['id']}", headers=actor(eve))
|
|
assert response.status_code == 404
|
|
assert response.json()["error"]["code"] == "not_found"
|
|
|
|
|
|
async def test_unknown_chat_is_indistinguishable_from_foreign(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
foreign = await client.get(f"/api/v1/chats/{chat['id']}", headers=actor(eve))
|
|
missing = await client.get(f"/api/v1/chats/{uuid4()}", headers=actor(eve))
|
|
assert foreign.status_code == missing.status_code == 404
|
|
assert foreign.json()["error"]["code"] == missing.json()["error"]["code"]
|
|
assert foreign.json()["error"]["message"] == missing.json()["error"]["message"]
|
|
|
|
|
|
async def test_outsider_cannot_write(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
json={"text": "чужое"},
|
|
headers=keyed(eve),
|
|
)
|
|
assert response.status_code == 404
|
|
history = await client.get(f"/api/v1/chats/{chat['id']}/messages", headers=actor(alice))
|
|
assert history.json()["items"] == []
|
|
|
|
|
|
async def test_outsider_cannot_read_history(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.get(f"/api/v1/chats/{chat['id']}/messages", headers=actor(eve))
|
|
assert response.status_code == 404
|
|
|
|
|
|
async def test_access_checked_before_body(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
json={"text": ""},
|
|
headers=keyed(eve),
|
|
)
|
|
assert response.status_code == 404
|
|
|
|
|
|
async def test_chat_list_hides_foreign_chats(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
bob = await register(client, "bob")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice, bob)
|
|
for member in (alice, bob):
|
|
listed = await client.get("/api/v1/chats?limit=100", headers=actor(member))
|
|
assert any(item["id"] == chat["id"] for item in listed.json()["items"])
|
|
hidden = await client.get("/api/v1/chats?limit=100", headers=actor(eve))
|
|
assert hidden.json()["items"] == []
|
|
|
|
|
|
async def test_403_is_never_used(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
paths = [
|
|
f"/api/v1/chats/{chat['id']}",
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
]
|
|
for path in paths:
|
|
assert (await client.get(path, headers=actor(eve))).status_code != 403
|
|
|
|
|
|
async def test_request_shape_is_checked_before_access(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
for chat_id in (chat["id"], uuid4()):
|
|
path = f"/api/v1/chats/{chat_id}/messages"
|
|
unkeyed = await client.post(path, json={"text": "чужое"}, headers=actor(eve))
|
|
extra = await client.post(path, json={"text": "x", "a": 1}, headers=keyed(eve))
|
|
assert unkeyed.status_code == extra.status_code == 400
|
|
assert unkeyed.json()["error"]["code"] == extra.json()["error"]["code"] == "invalid_request"
|
|
blank = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages", json={"text": " "}, headers=keyed(eve)
|
|
)
|
|
assert blank.status_code == 404
|
|
|
|
|
|
async def test_outsider_does_not_wait_for_members_lock(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
holder = await asyncpg.connect(DATABASE["url"])
|
|
try:
|
|
async with holder.transaction():
|
|
await holder.execute("SELECT 1 FROM chats WHERE id = $1 FOR UPDATE", chat["id"])
|
|
started = time.perf_counter()
|
|
response = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages", json={"text": "чужое"}, headers=keyed(eve)
|
|
)
|
|
elapsed = time.perf_counter() - started
|
|
finally:
|
|
await holder.close()
|
|
assert response.status_code == 404
|
|
assert elapsed < 0.5
|