Mark a stale pending row in its own committed transaction before the
cleaner deletes the object, and let mark_ready promote only unmarked
rows, so a cleaner rollback after the object delete can no longer leave
a ready attachment without its object. Add fault checks for an unknown
COMMIT outcome, an upload outliving the grace period and a cleaner
failure after the object delete; fix the cleaner entrypoint in rules.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- upload: delete the stored object when ready fails before COMMIT or the
pending row is gone (503 instead of 500); unknown COMMIT outcome keeps it
- cleaner service (python -m src.cleaner): stale pending rows older than
grace (900 s, must exceed 17 s live-upload bound) under FOR UPDATE SKIP
LOCKED, object before row, own S3 user with read/delete only
- shared session_scope for API and cleaner; early_stop process name
- partial index on pending attachments, CREATE INDEX CONCURRENTLY
- s3-bootstrap: cleaner user, policy and checks; make env_setup appends
missing template variables to an existing .env
- failure checks: cleaner on the failure stand, id-list hook actions,
five new and three updated tests; driver upload-consistency
- sync upload-consistency deltas into main specs (storage-consistency)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- keep one upload body in memory: BytesIO + getvalue() without copy,
fixed glibc mmap threshold in the image (no realloc copy on growth)
- stop PNG inflate at expected size + 1 byte
- reject filename that is not valid UTF-8 after percent-decoding (400)
- failure stand: env limit variables do not change attachment limits;
history with attachment_ids while S3 is stopped
- drop dead constants; restate "old image on new schema" scenario
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- upload, metadata and download endpoints for PNG/JPEG attachments:
limits before reading and decompression, type by content,
structural integrity check without decoding pixels, safe filename
- write order: pending row with object key -> PUT to S3 -> ready;
per-step DB sessions so no pool connection is held during transfers
- attachment_ids in messages (validation, idempotency hash, history);
whitespace-only text allowed with an attachment (teacher, 2026-10-20)
- migration: attachments and message_attachments tables, text length
CHECK relaxed with NOT VALID
- student tests, fault checks and driver commands for attachments;
rollout profile starts from e1161f7 and checks the commit first
- sync attachments deltas into main specs; rules, AGENTS.md, PLAN.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>