diff --git a/openspec/changes/close-lab3-review-gaps/tasks.md b/openspec/changes/close-lab3-review-gaps/tasks.md index bd49e929..753fb1b2 100644 --- a/openspec/changes/close-lab3-review-gaps/tasks.md +++ b/openspec/changes/close-lab3-review-gaps/tasks.md @@ -1,6 +1,6 @@ ## 1. Требования и код -- [ ] 1.1 Тест порядка проверок `POST …/messages` для постороннего (`test_request_shape_is_checked_before_access`) +- [x] 1.1 Тест порядка проверок `POST …/messages` для постороннего (`test_request_shape_is_checked_before_access`) - [ ] 1.2 Убрать `# type: ignore` из `shared/entrypoints/errors.py` - [ ] 1.3 `openspec/config.yaml`: `gunicorn_conf.py` в карте модулей - [ ] 1.4 Проверка группы: `make lint`, `make student-test`, `make check` diff --git a/student-tests/api/test_access.py b/student-tests/api/test_access.py index 8a623623..65dd052c 100644 --- a/student-tests/api/test_access.py +++ b/student-tests/api/test_access.py @@ -82,3 +82,19 @@ async def test_403_is_never_used(client: AsyncClient) -> None: ] for path in paths: assert (await client.get(path, headers=actor(eve))).status_code != 403 + + +async def test_request_shape_is_checked_before_access(client: AsyncClient) -> None: + alice = await register(client, "alice") + eve = await register(client, "eve") + chat = await make_chat(client, alice) + for chat_id in (chat["id"], uuid4()): + path = f"/api/v1/chats/{chat_id}/messages" + unkeyed = await client.post(path, json={"text": "чужое"}, headers=actor(eve)) + extra = await client.post(path, json={"text": "x", "a": 1}, headers=keyed(eve)) + assert unkeyed.status_code == extra.status_code == 400 + assert unkeyed.json()["error"]["code"] == extra.json()["error"]["code"] == "invalid_request" + blank = await client.post( + f"/api/v1/chats/{chat['id']}/messages", json={"text": " "}, headers=keyed(eve) + ) + assert blank.status_code == 404