Реализовать общую идемпотентность отправки сообщения
Ключ Idempotency-Key с TTL (минимум 86400 c), таблица message_requests и advisory-лок на (пользователь, чат, ключ): конкурентные повторные запросы возвращают одно и то же сообщение, конфликт по body -> 409. Добавлена миграция 002 и сценарий проверки scripts/check_idempotency.py.
This commit is contained in:
+22
-1
@@ -1,5 +1,7 @@
|
||||
"""PostgreSQL repository: all SQL values are bound parameters."""
|
||||
from datetime import datetime, timezone
|
||||
import hashlib
|
||||
import json
|
||||
from uuid import UUID, uuid4
|
||||
import psycopg
|
||||
from .domain import ApiError, invalid
|
||||
@@ -112,11 +114,30 @@ class PostgresRepository:
|
||||
' ORDER BY c.created_at,c.id LIMIT %s', params).fetchall()
|
||||
return [serialize(r) for r in rows]
|
||||
|
||||
def create_message(self, actor, chat_id, text):
|
||||
def create_message(self, actor, chat_id, text, key, ttl):
|
||||
# The operation is POST /chats/{id}/messages only. Method is implicit in
|
||||
# this dedicated table. A transaction lock serializes this exact scope
|
||||
# across ALL processes; a hash collision only adds harmless contention.
|
||||
scope = json.dumps([actor, chat_id, key], separators=(',', ':')).encode()
|
||||
lock_id = int.from_bytes(hashlib.sha256(scope).digest()[:8], 'big', signed=True)
|
||||
with self.db.transaction() as conn:
|
||||
self._access(conn, actor, chat_id)
|
||||
conn.execute('SELECT pg_advisory_xact_lock(%s)', (lock_id,))
|
||||
previous = conn.execute("""SELECT r.request_text, m.* FROM message_requests r
|
||||
JOIN messages m ON m.id=r.message_id
|
||||
WHERE r.user_id=%s AND r.chat_id=%s AND r.idempotency_key=%s
|
||||
AND r.expires_at>clock_timestamp()""", (actor, chat_id, key)).fetchone()
|
||||
if previous:
|
||||
if previous.pop('request_text') != text:
|
||||
raise ApiError(409, 'conflict', 'Idempotency key already used with another message')
|
||||
return serialize(previous)
|
||||
conn.execute('DELETE FROM message_requests WHERE user_id=%s AND chat_id=%s AND idempotency_key=%s',
|
||||
(actor, chat_id, key))
|
||||
row = conn.execute('INSERT INTO messages(id,chat_id,sender_id,text) VALUES (%s,%s,%s,%s) RETURNING *',
|
||||
(uuid4(), chat_id, actor, text)).fetchone()
|
||||
conn.execute("""INSERT INTO message_requests(user_id,chat_id,idempotency_key,request_text,message_id,expires_at)
|
||||
VALUES (%s,%s,%s,%s,%s,clock_timestamp() + %s * interval '1 second')""",
|
||||
(actor, chat_id, key, text, row['id'], ttl))
|
||||
return serialize(row)
|
||||
|
||||
def messages(self, actor, chat_id, limit, after):
|
||||
|
||||
Reference in New Issue
Block a user