POST /api/v1/chats/{chat_id}/messages now requires the header, checked
at the HTTP boundary (1-128 of [A-Za-z0-9._:-], else 400). The handler
keeps the lab 2 order under the chat row lock: membership, then text,
then the receipt for (chat, sender, key) younger than
IDEMPOTENCY_TTL_SECONDS. A receipt with the same fingerprint replays
the stored message, a different one is 409 conflict; without a
receipt one statement inserts the message, the key row and the chat
mark, so both commit or neither does. Concurrent retries wait on the
same row lock and then read the committed receipt. The fingerprint is
SHA-256 of the canonical JSON of the parsed body, so layout does not
matter, and only 201 answers are ever stored.
A lock timeout now counts as a dependency failure and answers 503
instead of 500, so a retry with the same key is safe.
Own tests cover replay, a different layout of the same JSON, conflict,
missing and malformed keys, rejected attempts that leave the key free,
scope by user and chat, revalidation after logout and for outsiders,
expiry, and eight concurrent retries through two app instances
sharing one PostgreSQL. Every earlier message post sends a fresh key.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
85 lines
3.3 KiB
Python
85 lines
3.3 KiB
Python
from uuid import uuid4
|
|
|
|
from httpx import AsyncClient
|
|
|
|
from conftest import actor, keyed, make_chat, register
|
|
|
|
|
|
async def test_outsider_gets_404_on_chat(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
bob = await register(client, "bob")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice, bob)
|
|
response = await client.get(f"/api/v1/chats/{chat['id']}", headers=actor(eve))
|
|
assert response.status_code == 404
|
|
assert response.json()["error"]["code"] == "not_found"
|
|
|
|
|
|
async def test_unknown_chat_is_indistinguishable_from_foreign(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
foreign = await client.get(f"/api/v1/chats/{chat['id']}", headers=actor(eve))
|
|
missing = await client.get(f"/api/v1/chats/{uuid4()}", headers=actor(eve))
|
|
assert foreign.status_code == missing.status_code == 404
|
|
assert foreign.json()["error"]["code"] == missing.json()["error"]["code"]
|
|
assert foreign.json()["error"]["message"] == missing.json()["error"]["message"]
|
|
|
|
|
|
async def test_outsider_cannot_write(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
json={"text": "чужое"},
|
|
headers=keyed(eve),
|
|
)
|
|
assert response.status_code == 404
|
|
history = await client.get(f"/api/v1/chats/{chat['id']}/messages", headers=actor(alice))
|
|
assert history.json()["items"] == []
|
|
|
|
|
|
async def test_outsider_cannot_read_history(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.get(f"/api/v1/chats/{chat['id']}/messages", headers=actor(eve))
|
|
assert response.status_code == 404
|
|
|
|
|
|
async def test_access_checked_before_body(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
json={"text": ""},
|
|
headers=keyed(eve),
|
|
)
|
|
assert response.status_code == 404
|
|
|
|
|
|
async def test_chat_list_hides_foreign_chats(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
bob = await register(client, "bob")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice, bob)
|
|
for member in (alice, bob):
|
|
listed = await client.get("/api/v1/chats?limit=100", headers=actor(member))
|
|
assert any(item["id"] == chat["id"] for item in listed.json()["items"])
|
|
hidden = await client.get("/api/v1/chats?limit=100", headers=actor(eve))
|
|
assert hidden.json()["items"] == []
|
|
|
|
|
|
async def test_403_is_never_used(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
paths = [
|
|
f"/api/v1/chats/{chat['id']}",
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
]
|
|
for path in paths:
|
|
assert (await client.get(path, headers=actor(eve))).status_code != 403
|