Commit Graph
16 Commits
Author SHA1 Message Date
ricoromaandClaude Opus 5.5 5b65051a60 test: add automatic failure checks on a separate stand
make failure_checks brings up a throwaway compose project with its own
PostgreSQL and Valkey, a default and a tight API (2 s sessions, pool of
one), and runs the pytest tests marked fault through an explicit hook:
session expiry, database stop and return, pool exhaustion, chat creation
rollback, readiness, Valkey stop, hang, return and flush. The stand and
its volume are removed on any outcome; the working stand is untouched.
Regular runs deselect the fault tests, and 13 coverage exclusions go away.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 23:20:34 +03:00
ricoromaandClaude Opus 5.5 3e79c6360f chore: archive membership-cache change
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 22:12:31 +03:00
ricoromaandClaude Opus 5.5 287a61c704 docs: re-shoot Valkey outage and restart evidence
Evidence from d7c9a59: Valkey stop adds 97 ms (one reconnect), pause
207 ms, 30 concurrent commands stay within 201 ms, and restarting Valkey
alone no longer switches the cache off. REPORT.md and the skill describe
the retry on a dropped connection.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 22:07:35 +03:00
ricoromaandClaude Opus 5.5 d7c9a5972b fix: retry Valkey once on a dropped connection
The client passed the sync redis.retry.Retry to async connections, so no
retry could ever run. Use redis.asyncio.retry.Retry with one immediate
retry on ConnectionError only: after a Valkey restart the stale pooled
connection is reopened instead of switching the cache off for 5 s.
Timeouts are not retried, and asyncio.timeout bounds each cache command
(pool wait, connect, retry, reply) by [cache] timeout_seconds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 21:41:15 +03:00
ricoromaandClaude Opus 5.5 25a60d36cd docs: add membership-cache evidence and report
Evidence from cae4b09: cache hits against chats table reads, Valkey
stop/pause/restart and FLUSHALL, restart hook with Valkey, Valkey ports
and password from .env, and a fresh make test_isolated run (103 tests).
REPORT.md describes the role of Valkey, the service table and the new
level 4 rows. The cache-read check now counts seq_scan + idx_scan: the
small chats table is read by sequential scan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 21:31:55 +03:00
ricoromaandClaude Opus 5.5 cae4b09147 feat: cache chat cards in Valkey
Valkey 9.1 in compose caches the immutable chat card (title, members,
created_at) used by GET /chats/{id} and by the membership check of the
message endpoints. Cache-aside with a write after commit, keys per
database, TTL plus allkeys-lru, persistence off. redis-py runs without
retries; on failure the cache is skipped for a few seconds and requests
go to PostgreSQL. Readiness does not depend on Valkey.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 21:17:55 +03:00
ricoromaandClaude Opus 5.5 c7681b0e18 chore: archive session-auth change
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 19:49:41 +03:00
ricoromaandClaude Opus 5.5 7887e03ade fix: precompute dummy password hash at startup
- lifespan computes the dummy Argon2id hash: first unknown-user login
  takes as long as a wrong password
- evidence for session TTL from config.toml, default and environment
- REPORT.md: manual /docs check, TTL configuration row
- tasks.md: why checks ran on a separate dev database

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 19:16:18 +03:00
ricoromaandClaude Opus 5.5 0cef33335d docs: add session-auth evidence and report
- passwords and tokens: Argon2id hashes, no secrets in db and logs
- session expiry and database outage with a valid token
- make test-persistence and make test_isolated on ae4154e
- migration drops lab 1 data without passwords
- REPORT.md: sessions, defense scenario, evidence rows

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 18:59:53 +03:00
ricoromaandClaude Opus 5.5 ae4154eaf5 feat: add password login and bearer sessions
- Argon2id password hashes, KDF in a thread with its own limit
- POST /auth/sessions with Basic, DELETE /auth/sessions/current
- Bearer sessions in PostgreSQL, X-User-Id ignored
- migration drops lab 1 data without passwords
- student-tests on tokens, sessions spec and synced specs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 18:50:42 +03:00
ricoromaandClaude Opus 5.5 ee2643d21e chore: archive postgres-storage change
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 16:50:05 +03:00
ricoromaandClaude Opus 5.5 484914c38a docs: add evidence for postgres-storage verify fixes
- statement timeout: 503 and no SQL parameters in logs, before and after
- failed migration keeps the API from starting
- fresh clone: console from zero, then docker and make down
- restart evidence with docker compose ps

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 16:47:42 +03:00
ricoromaandClaude Opus 5.5 125145df15 fix: hide SQL parameters in database error logs
- hide_parameters=True in the engine, rule in infra.md
- design: 79 of 80 tests, $(PYTHON) for test_isolated
- AGENTS.md: hand off deferred scenarios
- REPORT.md: unknown outcome of a timed-out commit

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 16:41:47 +03:00
ricoromaandClaude Opus 5.5 2d0a7c83e9 feat: finish postgres-storage change
- keep engine and session factory in src/infra/db/session.py
- sync delta specs into openspec/specs, add db-migrations spec
- update rules, AGENTS.md and run skill for lab 2 storage
- fill REPORT.md for the storage part

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 16:20:49 +03:00
ricoromaandClaude Opus 5.5 4921afa39d feat: store messenger data in PostgreSQL
Replace the in-memory store with PostgreSQL 18.6: SQLAlchemy 2.1 async
engine on asyncpg, alembic migrations with an async env.py, repos on
AsyncSession and services that own the transaction. Username
uniqueness is enforced by the database (ON CONFLICT), a chat and its
members are created in one transaction, member order is kept in
chat_members.position, and a composite foreign key makes the sender a
member of the chat. History and chat lists use keyset pagination on
(chat_id, created_at, id) and (user_id, created_at, chat_id).

The compose stand runs postgres, a one-shot migrate service on the
API image and the API. All Postgres addresses come from .env without
literals; only the 127.0.0.1 publish address stays literal. make
run_dev starts Postgres and applies migrations before the server, and
make env_setup generates a random Postgres password.

Unavailable PostgreSQL yields 503: get_db_session bounds the request
with asyncio and classifies driver errors. BoundedCloseConnection
limits asyncpg's graceful close, which otherwise waited without limit
on a frozen server and held the request until it was resumed.

Add scripts/restart.sh for make test-persistence and make
test_isolated, which runs the image on a throwaway test database.
Remove make run_no_compose. X-User-Id identification is unchanged
until the session-auth change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 15:33:49 +03:00
ricoromaandClaude Opus 5.5 7b775a29a9 chore: carry over lab 1 solution into lab 2 skeleton
Copy the committed lab 1 sources as-is: src/, student-tests/, bench/,
Dockerfile, docker-compose.yml, pyproject.toml, uv.lock,
.python-version, config_example.toml, AGENTS.md, CLAUDE.md, .claude/,
openspec/, .graphifyignore and KNOWN_ISSUES.md. Lab 1 evidence stays
in the lab 1 repository.

Merge the new skeleton files with own sections: Makefile (lab 2
targets plus own run, docker, bench and common targets), .gitignore,
.dockerignore and .env.example. Rename the image to
mtusi-messenger:lab2 and point AGENTS.md at lab 2.

The application is still the in-memory lab 1 implementation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-30 22:11:46 +03:00