forked from mtusi2026/mtusi2026lab4
457 lines
16 KiB
Go
457 lines
16 KiB
Go
package messenger
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"image"
|
|
"image/color"
|
|
"image/png"
|
|
"io"
|
|
"log/slog"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
"golang.org/x/sync/semaphore"
|
|
|
|
"gitea.privcloud.tech/dizi/mtusi2026lab4/internal/model"
|
|
"gitea.privcloud.tech/dizi/mtusi2026lab4/internal/postgres"
|
|
)
|
|
|
|
var errDependency = errors.New("dependency unavailable")
|
|
|
|
type MessengerSuite struct {
|
|
suite.Suite
|
|
logger *slog.Logger
|
|
}
|
|
|
|
func TestMessengerSuite(t *testing.T) {
|
|
suite.Run(t, new(MessengerSuite))
|
|
}
|
|
|
|
func (s *MessengerSuite) SetupTest() {
|
|
s.logger = slog.New(slog.NewTextHandler(io.Discard, nil))
|
|
}
|
|
|
|
type messengerStoreStub struct {
|
|
pingErr error
|
|
userByID model.User
|
|
userByIDErr error
|
|
credentials model.UserCredentials
|
|
credentialsErr error
|
|
message model.Message
|
|
messageReplay bool
|
|
messageErr error
|
|
attachment model.Attachment
|
|
attachmentErr error
|
|
storedAttachment model.Attachment
|
|
storedAttachmentExists bool
|
|
storedAttachmentErr error
|
|
}
|
|
|
|
func (s messengerStoreStub) Ping(context.Context) error { return s.pingErr }
|
|
func (messengerStoreStub) CreateUser(context.Context, string, string, string) (model.User, error) {
|
|
return model.User{}, nil
|
|
}
|
|
func (s messengerStoreStub) UserByID(context.Context, string) (model.User, error) {
|
|
return s.userByID, s.userByIDErr
|
|
}
|
|
func (s messengerStoreStub) UserByUsername(context.Context, string) (model.UserCredentials, error) {
|
|
return s.credentials, s.credentialsErr
|
|
}
|
|
func (messengerStoreStub) CreateChat(context.Context, string, []string, string) (model.Chat, error) {
|
|
return model.Chat{}, nil
|
|
}
|
|
func (messengerStoreStub) ChatForUser(context.Context, string, string) (model.Chat, error) {
|
|
return model.Chat{}, nil
|
|
}
|
|
func (messengerStoreStub) ListChats(context.Context, string, *model.Position, int) ([]model.Chat, bool, error) {
|
|
return nil, false, nil
|
|
}
|
|
func (s messengerStoreStub) CreateMessage(context.Context, string, string, string, []string, string, time.Duration) (model.Message, bool, error) {
|
|
return s.message, s.messageReplay, s.messageErr
|
|
}
|
|
func (messengerStoreStub) ListMessages(context.Context, string, string, *model.Position, int) ([]model.Message, bool, error) {
|
|
return nil, false, nil
|
|
}
|
|
func (s messengerStoreStub) CreateAttachment(context.Context, model.Attachment) (model.Attachment, error) {
|
|
return s.attachment, s.attachmentErr
|
|
}
|
|
func (s messengerStoreStub) AttachmentByStorage(context.Context, string, string) (model.Attachment, error) {
|
|
if s.storedAttachmentErr != nil {
|
|
return model.Attachment{}, s.storedAttachmentErr
|
|
}
|
|
if !s.storedAttachmentExists {
|
|
return model.Attachment{}, postgres.ErrNotFound
|
|
}
|
|
return s.storedAttachment, nil
|
|
}
|
|
func (s messengerStoreStub) AttachmentForUser(context.Context, string, string) (model.Attachment, error) {
|
|
return s.attachment, s.attachmentErr
|
|
}
|
|
|
|
type objectStoreStub struct {
|
|
pingErr error
|
|
putErr error
|
|
getData []byte
|
|
getErr error
|
|
deleteErr error
|
|
putKey *string
|
|
deletedKey *string
|
|
}
|
|
|
|
func (s objectStoreStub) Ping(context.Context) error { return s.pingErr }
|
|
func (s objectStoreStub) Put(_ context.Context, key string, _ string, _ []byte) error {
|
|
if s.putKey != nil {
|
|
*s.putKey = key
|
|
}
|
|
return s.putErr
|
|
}
|
|
func (s objectStoreStub) Get(context.Context, string) (io.ReadCloser, error) {
|
|
if s.getErr != nil {
|
|
return nil, s.getErr
|
|
}
|
|
return io.NopCloser(bytes.NewReader(s.getData)), nil
|
|
}
|
|
func (s objectStoreStub) Delete(_ context.Context, key string) error {
|
|
if s.deletedKey != nil {
|
|
*s.deletedKey = key
|
|
}
|
|
return s.deleteErr
|
|
}
|
|
|
|
type sessionStub struct {
|
|
pingErr error
|
|
userID string
|
|
userIDErr error
|
|
}
|
|
|
|
func (s sessionStub) Ping(context.Context) error { return s.pingErr }
|
|
func (sessionStub) Create(context.Context, string, time.Duration) (string, time.Time, error) {
|
|
return "token", time.Now().Add(time.Hour), nil
|
|
}
|
|
func (s sessionStub) UserID(context.Context, string) (string, error) { return s.userID, s.userIDErr }
|
|
func (sessionStub) Delete(context.Context, string) error { return nil }
|
|
|
|
type passwordsStub struct {
|
|
verified bool
|
|
err error
|
|
}
|
|
|
|
func (passwordsStub) Hash(string) (string, error) { return "hash", nil }
|
|
func (passwordsStub) DummyHash() string { return "hash" }
|
|
func (s passwordsStub) Verify(string, string) (bool, error) {
|
|
return s.verified, s.err
|
|
}
|
|
|
|
func (s *MessengerSuite) TestReadinessReturnsUnavailableForDependencyFailure() {
|
|
t := s.T()
|
|
tests := []struct {
|
|
name string
|
|
store messengerStoreStub
|
|
sessions sessionStub
|
|
objects objectStoreStub
|
|
}{
|
|
{name: "postgres", store: messengerStoreStub{pingErr: errDependency}},
|
|
{name: "valkey", sessions: sessionStub{pingErr: errDependency}},
|
|
{name: "s3", objects: objectStoreStub{pingErr: errDependency}},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
server := NewServer(
|
|
s.logger, tt.store, tt.sessions, passwordsStub{}, tt.objects, time.Hour, 24*time.Hour,
|
|
time.Second, "test-instance", "8081", 10*1024*1024, 40_000_000, 384*1024*1024,
|
|
)
|
|
response := serveRequest(server, http.MethodGet, "/health/ready", "")
|
|
if response.Code != http.StatusServiceUnavailable {
|
|
t.Fatalf("status = %d, want %d", response.Code, http.StatusServiceUnavailable)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestBusinessRequestReturnsUnavailableForDependencyFailure() {
|
|
t := s.T()
|
|
tests := []struct {
|
|
name string
|
|
store messengerStoreStub
|
|
sessions sessionStub
|
|
}{
|
|
{name: "valkey", sessions: sessionStub{userIDErr: errDependency}},
|
|
{name: "postgres", store: messengerStoreStub{userByIDErr: errDependency}, sessions: sessionStub{userID: "user-id"}},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
server := s.newTestServer(tt.store, tt.sessions, passwordsStub{})
|
|
request := httptest.NewRequest(http.MethodGet, "/api/v1/users/me", nil)
|
|
request.Header.Set("Authorization", "Bearer valid-token")
|
|
response := httptest.NewRecorder()
|
|
server.Handler().ServeHTTP(response, request)
|
|
if response.Code != http.StatusServiceUnavailable {
|
|
t.Fatalf("status = %d, want %d", response.Code, http.StatusServiceUnavailable)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestAuthenticationChallenges() {
|
|
t := s.T()
|
|
server := s.newTestServer(messengerStoreStub{}, sessionStub{}, passwordsStub{})
|
|
bearer := serveRequest(server, http.MethodGet, "/api/v1/users/me", "")
|
|
if bearer.Code != http.StatusUnauthorized || bearer.Header().Get("WWW-Authenticate") != `Bearer realm="messenger"` {
|
|
t.Fatalf("business challenge = %d %q", bearer.Code, bearer.Header().Get("WWW-Authenticate"))
|
|
}
|
|
|
|
store := messengerStoreStub{credentials: model.UserCredentials{PasswordHash: "hash"}}
|
|
server = s.newTestServer(store, sessionStub{}, passwordsStub{verified: false})
|
|
request := httptest.NewRequest(http.MethodPost, "/api/v1/auth/sessions", nil)
|
|
request.SetBasicAuth("user", "wrong-password")
|
|
response := httptest.NewRecorder()
|
|
server.Handler().ServeHTTP(response, request)
|
|
if response.Code != http.StatusUnauthorized || response.Header().Get("WWW-Authenticate") != `Basic realm="messenger", charset="UTF-8"` {
|
|
t.Fatalf("session challenge = %d %q", response.Code, response.Header().Get("WWW-Authenticate"))
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestAttachmentContentAuthenticatesBeforeVariantValidation() {
|
|
server := s.newTestServer(messengerStoreStub{}, sessionStub{}, passwordsStub{})
|
|
response := serveRequest(
|
|
server,
|
|
http.MethodGet,
|
|
"/api/v1/attachments/00000000-0000-0000-0000-000000000001/content?variant=invalid",
|
|
"",
|
|
)
|
|
s.Equal(http.StatusUnauthorized, response.Code)
|
|
s.Equal(`Bearer realm="messenger"`, response.Header().Get("WWW-Authenticate"))
|
|
}
|
|
|
|
func (s *MessengerSuite) TestSessionCreationRejectsChunkedBody() {
|
|
t := s.T()
|
|
server := s.newTestServer(messengerStoreStub{}, sessionStub{}, passwordsStub{})
|
|
request := httptest.NewRequest(http.MethodPost, "/api/v1/auth/sessions", strings.NewReader("{}"))
|
|
request.ContentLength = -1
|
|
request.SetBasicAuth("user", "password")
|
|
response := httptest.NewRecorder()
|
|
server.Handler().ServeHTTP(response, request)
|
|
if response.Code != http.StatusBadRequest {
|
|
t.Fatalf("status = %d, want %d", response.Code, http.StatusBadRequest)
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestRegistrationRejectsWhitespacePassword() {
|
|
t := s.T()
|
|
server := s.newTestServer(messengerStoreStub{}, sessionStub{}, passwordsStub{})
|
|
response := serveRequest(server, http.MethodPost, "/api/v1/users", `{"username":"student","display_name":"Student","password":" "}`)
|
|
if response.Code != http.StatusBadRequest {
|
|
t.Fatalf("status = %d, want %d", response.Code, http.StatusBadRequest)
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestInstanceHeaderIsSetOnSuccessAndError() {
|
|
t := s.T()
|
|
server := s.newTestServer(messengerStoreStub{}, sessionStub{}, passwordsStub{})
|
|
for _, response := range []*httptest.ResponseRecorder{
|
|
serveRequest(server, http.MethodGet, "/health/live", ""),
|
|
serveRequest(server, http.MethodGet, "/api/v1/users/me", ""),
|
|
} {
|
|
if value := response.Header().Get("X-Instance-Id"); value != "test-instance" {
|
|
t.Fatalf("X-Instance-Id = %q, want test-instance", value)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestMessageCreationValidatesIdempotencyKey() {
|
|
t := s.T()
|
|
store := messengerStoreStub{userByID: model.User{ID: "user-id"}}
|
|
server := s.newTestServer(store, sessionStub{userID: "user-id"}, passwordsStub{})
|
|
tests := []struct {
|
|
name string
|
|
key string
|
|
}{
|
|
{name: "missing"},
|
|
{name: "invalid", key: "invalid key"},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
request := httptest.NewRequest(http.MethodPost, "/api/v1/chats/00000000-0000-0000-0000-000000000001/messages", strings.NewReader(`{"text":"message"}`))
|
|
request.Header.Set("Authorization", "Bearer valid-token")
|
|
request.Header.Set("Content-Type", "application/json")
|
|
if tt.key != "" {
|
|
request.Header.Set("Idempotency-Key", tt.key)
|
|
}
|
|
response := httptest.NewRecorder()
|
|
server.Handler().ServeHTTP(response, request)
|
|
if response.Code != http.StatusBadRequest {
|
|
t.Fatalf("status = %d, want %d", response.Code, http.StatusBadRequest)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestMessageCreationReturnsConflictForReusedKeyWithDifferentBody() {
|
|
t := s.T()
|
|
store := messengerStoreStub{
|
|
userByID: model.User{ID: "user-id"},
|
|
messageErr: fmt.Errorf("create message: %w", postgres.ErrIdempotencyConflict),
|
|
}
|
|
server := s.newTestServer(store, sessionStub{userID: "user-id"}, passwordsStub{})
|
|
request := httptest.NewRequest(http.MethodPost, "/api/v1/chats/00000000-0000-0000-0000-000000000001/messages", strings.NewReader(`{"text":"different"}`))
|
|
request.Header.Set("Authorization", "Bearer valid-token")
|
|
request.Header.Set("Content-Type", "application/json")
|
|
request.Header.Set("Idempotency-Key", "same-key")
|
|
response := httptest.NewRecorder()
|
|
server.Handler().ServeHTTP(response, request)
|
|
if response.Code != http.StatusConflict {
|
|
t.Fatalf("status = %d, want %d", response.Code, http.StatusConflict)
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestImageValidation() {
|
|
data := testPNG(s.T(), 2, 2)
|
|
tests := []struct {
|
|
name string
|
|
contentType string
|
|
data []byte
|
|
maxBytes int64
|
|
maxPixels int64
|
|
wantStatus int
|
|
}{
|
|
{name: "valid", contentType: "image/png", data: data, maxBytes: 1024, maxPixels: 4},
|
|
{name: "spoofed MIME", contentType: "image/jpeg", data: data, maxBytes: 1024, maxPixels: 4, wantStatus: http.StatusUnsupportedMediaType},
|
|
{name: "too many pixels", contentType: "image/png", data: data, maxBytes: 1024, maxPixels: 3, wantStatus: http.StatusRequestEntityTooLarge},
|
|
{name: "too many bytes", contentType: "image/png", data: data, maxBytes: int64(len(data) - 1), maxPixels: 4, wantStatus: http.StatusRequestEntityTooLarge},
|
|
{name: "damaged", contentType: "image/png", data: data[:16], maxBytes: 1024, maxPixels: 4, wantStatus: http.StatusUnsupportedMediaType},
|
|
}
|
|
for _, tt := range tests {
|
|
s.Run(tt.name, func() {
|
|
request := httptest.NewRequest(http.MethodPost, "/upload", bytes.NewReader(tt.data))
|
|
request.Header.Set("Content-Type", tt.contentType)
|
|
response := httptest.NewRecorder()
|
|
actual, _, apiErr := readImage(
|
|
response, request, tt.maxBytes, tt.maxPixels, semaphore.NewWeighted(384*1024*1024),
|
|
)
|
|
if tt.wantStatus == 0 {
|
|
s.Require().Nil(apiErr)
|
|
s.Equal(tt.data, actual)
|
|
return
|
|
}
|
|
s.Require().NotNil(apiErr)
|
|
s.Equal(tt.wantStatus, apiErr.status)
|
|
})
|
|
}
|
|
}
|
|
|
|
func (s *MessengerSuite) TestImageValidationLimitsConcurrentDecodeMemory() {
|
|
data := testPNG(s.T(), 2, 2)
|
|
request := httptest.NewRequest(http.MethodPost, "/upload", bytes.NewReader(data))
|
|
request.Header.Set("Content-Type", "image/png")
|
|
response := httptest.NewRecorder()
|
|
_, _, apiErr := readImage(response, request, 1024, 4, semaphore.NewWeighted(1))
|
|
s.Require().NotNil(apiErr)
|
|
s.Equal(http.StatusTooManyRequests, apiErr.status)
|
|
s.Equal("1", response.Header().Get("Retry-After"))
|
|
}
|
|
|
|
func (s *MessengerSuite) TestAttachmentFilenameValidation() {
|
|
for _, filename := range []string{"", " ", "../photo.png", "dir\\photo.png", "photo\x00.png", "photo\n.png"} {
|
|
_, valid := attachmentFilename(map[string][]string{"filename": {filename}})
|
|
s.False(valid, filename)
|
|
}
|
|
filename, valid := attachmentFilename(map[string][]string{"filename": {"фото.png"}})
|
|
s.True(valid)
|
|
s.Equal("фото.png", filename)
|
|
}
|
|
|
|
func (s *MessengerSuite) TestUploadCompensatesObjectWhenMetadataWriteFails() {
|
|
var putKey, deletedKey string
|
|
store := messengerStoreStub{
|
|
userByID: model.User{ID: "00000000-0000-0000-0000-000000000001"},
|
|
attachmentErr: errDependency,
|
|
}
|
|
objects := objectStoreStub{putKey: &putKey, deletedKey: &deletedKey}
|
|
server := NewServer(
|
|
s.logger, store, sessionStub{userID: store.userByID.ID}, passwordsStub{}, objects,
|
|
time.Hour, 24*time.Hour, time.Second, "test-instance", "8081", 10*1024*1024, 40_000_000, 384*1024*1024,
|
|
)
|
|
data := testPNG(s.T(), 2, 2)
|
|
request := httptest.NewRequest(
|
|
http.MethodPost,
|
|
"/api/v1/chats/00000000-0000-0000-0000-000000000002/attachments?filename=photo.png",
|
|
bytes.NewReader(data),
|
|
)
|
|
request.Header.Set("Authorization", "Bearer valid-token")
|
|
request.Header.Set("Content-Type", "image/png")
|
|
response := httptest.NewRecorder()
|
|
server.Handler().ServeHTTP(response, request)
|
|
s.Equal(http.StatusServiceUnavailable, response.Code)
|
|
s.NotEmpty(putKey)
|
|
s.Equal(putKey, deletedKey)
|
|
}
|
|
|
|
func (s *MessengerSuite) TestUploadKeepsObjectWhenMetadataCommitSucceeded() {
|
|
var deletedKey string
|
|
stored := model.Attachment{
|
|
ID: "00000000-0000-0000-0000-000000000003",
|
|
ChatID: "00000000-0000-0000-0000-000000000002",
|
|
OwnerID: "00000000-0000-0000-0000-000000000001",
|
|
Filename: "photo.png", ContentType: "image/png", SizeBytes: 1, SHA256: strings.Repeat("0", 64),
|
|
Status: "ready", Variants: []model.Variant{}, CreatedAt: time.Now(), UpdatedAt: time.Now(),
|
|
}
|
|
store := messengerStoreStub{
|
|
userByID: model.User{ID: stored.OwnerID}, attachmentErr: errDependency,
|
|
storedAttachment: stored, storedAttachmentExists: true,
|
|
}
|
|
server := NewServer(
|
|
s.logger, store, sessionStub{userID: stored.OwnerID}, passwordsStub{}, objectStoreStub{deletedKey: &deletedKey},
|
|
time.Hour, 24*time.Hour, time.Second, "test-instance", "8081", 10*1024*1024, 40_000_000, 384*1024*1024,
|
|
)
|
|
data := testPNG(s.T(), 2, 2)
|
|
request := httptest.NewRequest(
|
|
http.MethodPost,
|
|
"/api/v1/chats/00000000-0000-0000-0000-000000000002/attachments?filename=photo.png",
|
|
bytes.NewReader(data),
|
|
)
|
|
request.Header.Set("Authorization", "Bearer valid-token")
|
|
request.Header.Set("Content-Type", "image/png")
|
|
response := httptest.NewRecorder()
|
|
server.Handler().ServeHTTP(response, request)
|
|
s.Equal(http.StatusCreated, response.Code)
|
|
s.Empty(deletedKey)
|
|
}
|
|
|
|
func testPNG(t *testing.T, width, height int) []byte {
|
|
t.Helper()
|
|
var data bytes.Buffer
|
|
imageData := image.NewRGBA(image.Rect(0, 0, width, height))
|
|
imageData.Set(0, 0, color.White)
|
|
if err := png.Encode(&data, imageData); err != nil {
|
|
t.Fatalf("encode PNG: %v", err)
|
|
}
|
|
return data.Bytes()
|
|
}
|
|
|
|
func (s *MessengerSuite) newTestServer(messages MessengerStore, sessions SessionStore, passwords PasswordService) *Server {
|
|
return NewServer(
|
|
s.logger, messages, sessions, passwords, objectStoreStub{}, time.Hour, 24*time.Hour,
|
|
time.Second, "test-instance", "8081", 10*1024*1024, 40_000_000, 384*1024*1024,
|
|
)
|
|
}
|
|
|
|
func serveRequest(server *Server, method, path, body string) *httptest.ResponseRecorder {
|
|
request := httptest.NewRequest(method, path, strings.NewReader(body))
|
|
if body != "" {
|
|
request.Header.Set("Content-Type", "application/json")
|
|
}
|
|
response := httptest.NewRecorder()
|
|
server.Handler().ServeHTTP(response, request)
|
|
return response
|
|
}
|