forked from mtusi2026/mtusi2026lab2
A message now carries attachment_ids in the request, in every response, in the idempotent replay and in history, in the order they were sent. The chat aggregate checks membership first, then refuses whitespace text, more than ten or repeated attachments, and an empty text without attachments, so an outsider still gets 404 before any 400. The send statement inserts the links next to the message and the idempotency key, and the foreign key from message_attachments to attachments of the same chat turns an unknown or foreign attachment into 404 and rolls the whole send back, without the messaging zone reading the attachments table. Replay and history read the list with a subquery on the primary key. The request fingerprint covers the list, so a missing attachment_ids and [] are the same body while a different order is a conflict. The zone dependency test now covers three zones, and the SQL ownership test checks that every zone touches only its own tables. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
109 lines
4.9 KiB
Python
109 lines
4.9 KiB
Python
from typing import Any
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from httpx import AsyncClient
|
|
|
|
from conftest import actor, keyed, make_chat, register
|
|
from pictures import SAMPLE
|
|
|
|
|
|
async def attach(http: AsyncClient, user: dict[str, Any], chat: dict[str, Any]) -> str:
|
|
response = await http.post(
|
|
f"/api/v1/chats/{chat['id']}/attachments?filename=a.png",
|
|
content=SAMPLE,
|
|
headers={**actor(user), "Content-Type": "image/png"},
|
|
)
|
|
assert response.status_code == 201, response.text
|
|
return response.json()["id"]
|
|
|
|
|
|
async def send(
|
|
http: AsyncClient, user: dict[str, Any], chat: dict[str, Any], body: Any, key: str | None = None
|
|
) -> Any:
|
|
return await http.post(
|
|
f"/api/v1/chats/{chat['id']}/messages", json=body, headers=keyed(user, key)
|
|
)
|
|
|
|
|
|
async def scene(http: AsyncClient) -> tuple[dict[str, Any], ...]:
|
|
alice, bob, eve = [await register(http, label) for label in ("alice", "bob", "eve")]
|
|
return alice, bob, eve, await make_chat(http, alice, bob), await make_chat(http, alice)
|
|
|
|
|
|
async def test_text_message_carries_empty_list(client: AsyncClient) -> None:
|
|
alice, _, _, chat, _ = await scene(client)
|
|
response = await send(client, alice, chat, {"text": "привет"})
|
|
assert response.status_code == 201
|
|
assert response.json()["attachment_ids"] == []
|
|
|
|
|
|
async def test_empty_text_with_attachment_keeps_order(client: AsyncClient) -> None:
|
|
alice, bob, _, chat, _ = await scene(client)
|
|
ids = [await attach(client, alice, chat) for _ in range(3)]
|
|
ordered = [ids[2], ids[0], ids[1]]
|
|
response = await send(client, bob, chat, {"text": "", "attachment_ids": ordered})
|
|
assert response.status_code == 201, response.text
|
|
message = response.json()
|
|
assert message["attachment_ids"] == ordered
|
|
again = await send(client, alice, chat, {"text": "ещё раз", "attachment_ids": [ids[0]]})
|
|
assert again.status_code == 201
|
|
history = await client.get(f"/api/v1/chats/{chat['id']}/messages", headers=actor(bob))
|
|
assert history.json()["items"] == [message, again.json()]
|
|
|
|
|
|
async def test_replay_with_attachments_and_default_list(client: AsyncClient) -> None:
|
|
alice, _, _, chat, _ = await scene(client)
|
|
first_id, second_id = await attach(client, alice, chat), await attach(client, alice, chat)
|
|
body = {"text": "", "attachment_ids": [first_id, second_id]}
|
|
first = await send(client, alice, chat, body, "with-files")
|
|
assert (await send(client, alice, chat, body, "with-files")).json() == first.json()
|
|
swapped = {"text": "", "attachment_ids": [second_id, first_id]}
|
|
assert (await send(client, alice, chat, swapped, "with-files")).status_code == 409
|
|
plain = await send(client, alice, chat, {"text": "x"}, "plain")
|
|
explicit = await send(client, alice, chat, {"attachment_ids": [], "text": "x"}, "plain")
|
|
assert (explicit.status_code, explicit.json()) == (201, plain.json())
|
|
|
|
|
|
async def test_attachment_of_another_chat_or_unknown(client: AsyncClient) -> None:
|
|
alice, _, _, chat, solo = await scene(client)
|
|
foreign = await attach(client, alice, solo)
|
|
for ids in ([foreign], [str(uuid4())]):
|
|
response = await send(client, alice, chat, {"text": "x", "attachment_ids": ids})
|
|
assert response.status_code == 404
|
|
assert response.json()["error"]["code"] == "not_found"
|
|
history = await client.get(f"/api/v1/chats/{chat['id']}/messages", headers=actor(alice))
|
|
assert history.json()["items"] == []
|
|
|
|
|
|
@pytest.mark.parametrize("kind", ["eleven", "duplicate", "not-uuid", "empty", "blank"])
|
|
async def test_invalid_attachment_lists(client: AsyncClient, kind: str) -> None:
|
|
alice, _, _, chat, _ = await scene(client)
|
|
file = await attach(client, alice, chat)
|
|
body = {
|
|
"eleven": {"text": "x", "attachment_ids": [file] + [str(uuid4()) for _ in range(10)]},
|
|
"duplicate": {"text": "x", "attachment_ids": [file, file]},
|
|
"not-uuid": {"text": "x", "attachment_ids": ["not-a-uuid"]},
|
|
"empty": {"text": "", "attachment_ids": []},
|
|
"blank": {"text": " ", "attachment_ids": [file]},
|
|
}[kind]
|
|
response = await send(client, alice, chat, body)
|
|
assert response.status_code == 400, response.text
|
|
assert response.json()["error"]["code"] == "invalid_request"
|
|
|
|
|
|
async def test_outsider_gets_not_found_before_validation(client: AsyncClient) -> None:
|
|
alice, _, eve, chat, _ = await scene(client)
|
|
file = await attach(client, alice, chat)
|
|
for body in ({"text": "", "attachment_ids": []}, {"text": "x", "attachment_ids": [file] * 11}):
|
|
assert (await send(client, eve, chat, body)).status_code == 404
|
|
|
|
|
|
async def test_one_attachment_in_several_messages(client: AsyncClient) -> None:
|
|
alice, bob, _, chat, _ = await scene(client)
|
|
file = await attach(client, alice, chat)
|
|
for user in (alice, bob):
|
|
response = await send(client, user, chat, {"text": "", "attachment_ids": [file]})
|
|
assert response.status_code == 201
|
|
assert response.json()["attachment_ids"] == [file]
|