diff --git a/evidence/review-png-memory-2026-11-07/RESULTS.md b/evidence/review-png-memory-2026-11-07/RESULTS.md index 5e359ca..5f746da 100644 --- a/evidence/review-png-memory-2026-11-07/RESULTS.md +++ b/evidence/review-png-memory-2026-11-07/RESULTS.md @@ -41,6 +41,9 @@ Runtime изменён только в `src/messenger/attachments/infrastructure | `make validate` | PASS OpenAPI 3.1 и JSON Schema | [validate.txt](validate.txt) | | `make lint` перед коммитом реализации | PASS ruff check/format и ty | [lint-implementation.txt](lint-implementation.txt) | | `openspec validate --all --strict` до архивации | 23 passed | [openspec-before-archive.txt](openspec-before-archive.txt) | +| `openspec validate --specs --strict`, затем `openspec validate --all --strict` после архивации | 22 passed, дельта синхронизирована | [specs-sync.txt](specs-sync.txt), [openspec-after-archive.txt](openspec-after-archive.txt) | +| `openspec list --json` после архивации | Активных changes нет | [active-changes-after.json](active-changes-after.json) | +| `make lint` перед архивным коммитом | PASS | [lint-archive.txt](lint-archive.txt) | Регрессия на изображениях 1025×769 учитывает одновременно живущие Pillow core, уникальные по identity, через weakref и перехват выделений. Размер пиксельных буферов: @@ -109,3 +112,16 @@ FAIL приложения и не включены в итоговые PASS. расхождение часов прежних измерений и `201` в design-правиле config. Они уже отражены в REPORT. Закрытие назначенного major на уровне реализации не превращает исходные FAIL в PASS; итоговый вердикт требует Linux/HTTP evidence нового SHA. + +## Завершение OpenSpec + +Коммит реализации: `1a8020524909ebc5e2e43303436c9d1ce3c1a87b`. +Change архивирован в `openspec/changes/archive/2026-11-07-fix-lab5-png-memory`, +все шесть задач завершены в границах offline-фазы. Сценарий добавлен в основную +спецификацию без удаления прежних сценариев. Хеши файлов — [checks.json](checks.json). + +Первая попытка переноса архива остановилась до rename из-за обращения к `lab.json.lab` +вместо существующего `lab.json.number`. Проверки в этот момент показывали 23 элемента +и активный завершённый change: [openspec-before-move.txt](openspec-before-move.txt), +[active-changes-before-move.json](active-changes-before-move.json). После исправления +ключа архивирование выполнено, итог — 22 спецификации и пустой список changes. diff --git a/evidence/review-png-memory-2026-11-07/active-changes-after.json b/evidence/review-png-memory-2026-11-07/active-changes-after.json new file mode 100644 index 0000000..c1f7be3 --- /dev/null +++ b/evidence/review-png-memory-2026-11-07/active-changes-after.json @@ -0,0 +1,7 @@ +{ + "changes": [], + "root": { + "path": "/Users/artemkostylev/projects/learning/HL/labs/mtusi2026lab5", + "source": "nearest" + } +} diff --git a/evidence/review-png-memory-2026-11-07/active-changes-before-move.json b/evidence/review-png-memory-2026-11-07/active-changes-before-move.json new file mode 100644 index 0000000..04f201d --- /dev/null +++ b/evidence/review-png-memory-2026-11-07/active-changes-before-move.json @@ -0,0 +1,15 @@ +{ + "changes": [ + { + "name": "fix-lab5-png-memory", + "completedTasks": 6, + "totalTasks": 6, + "lastModified": "2026-11-06T21:47:57.394Z", + "status": "complete" + } + ], + "root": { + "path": "/Users/artemkostylev/projects/learning/HL/labs/mtusi2026lab5", + "source": "nearest" + } +} diff --git a/evidence/review-png-memory-2026-11-07/checks.json b/evidence/review-png-memory-2026-11-07/checks.json index 76d6c81..ca6f532 100644 --- a/evidence/review-png-memory-2026-11-07/checks.json +++ b/evidence/review-png-memory-2026-11-07/checks.json @@ -1,19 +1,34 @@ { "baseline_sha": "fb682bc38476d785d02d4611ba4913e5f37bed62", + "implementation_sha": "1a8020524909ebc5e2e43303436c9d1ce3c1a87b", + "local_links_verified": 18, + "delta_synced": true, "sha256": { "src/messenger/attachments/infrastructure/images.py": "97c6e9c1ef13c8854be9cd2cc11e4279d1d340ba3ab360dfa3e05772923ea743", "student-tests/unit/test_png_memory.py": "49d9fa001d82a2fd495e11da5793ec7f42dfdeb7b0929866e6a0ef94a35f440d", - "evidence/review-png-memory-2026-11-07/RESULTS.md": "2f4e5da18f110420170ad6adf97982797670775d62bb31fb549ab36804a99e01", + "openspec/specs/lab5-image-variants/spec.md": "5473601ca6d24a244e7c5023466a2bb5708ce16a46415bd81b35fe5e5baed578", + "openspec/changes/archive/2026-11-07-fix-lab5-png-memory/.openspec.yaml": "273fea3c6a19b7108aad9607468b03a0a122e03d8660eb157f3cd8c7e4a46737", + "openspec/changes/archive/2026-11-07-fix-lab5-png-memory/design.md": "bb5f6cbafcd3828d7e81ff14954d04bc22ac42668c71178ea5c62a6baa08f72e", + "openspec/changes/archive/2026-11-07-fix-lab5-png-memory/proposal.md": "d15889bf0f14b253009c072048b1822dbe8e08b8a230a0d1939f817939139a37", + "openspec/changes/archive/2026-11-07-fix-lab5-png-memory/specs/lab5-image-variants/spec.md": "8686927a82a34a2b40e948a6680d0f360b1748b8ce87f8d883ef2cca70bb9a72", + "openspec/changes/archive/2026-11-07-fix-lab5-png-memory/tasks.md": "67dd25059098324246d13204d36c553e4b91f32d6a7efc5da7abb5594fa8b040", + "evidence/review-png-memory-2026-11-07/RESULTS.md": "22ae535500e9aa2479851a139126a3e36143eda3e55022ba8df44a834eebc660", + "evidence/review-png-memory-2026-11-07/active-changes-after.json": "b00cf723b88fd2254414abeb7b15015c4fb94a28303b44b59ea542fc57bbdcda", + "evidence/review-png-memory-2026-11-07/active-changes-before-move.json": "99136b09ad0ffbbdddc938f0ec5ffab8b4e2b29b7311c44f55a5cbc72d0b7f1f", "evidence/review-png-memory-2026-11-07/boundaries.txt": "a4d0778a9ba058ff75b48cb3a145ac59e8c7ae9f3764db8fb6a0425c242bf8d2", "evidence/review-png-memory-2026-11-07/check.txt": "5f42d25d7cd8c1d2fb31ccf28a2872fbb91d38ed094024181e5ace9671667ee6", "evidence/review-png-memory-2026-11-07/compatibility-command.txt": "09d5bbe4568422aa69917031cf1e6ba8ccc3cf7f241ac88343812f8bf231176d", "evidence/review-png-memory-2026-11-07/compatibility.txt": "bd3bf1841e476fcc62d6266123bfcf21dc259bf89160a4dda31ba301f429c57d", "evidence/review-png-memory-2026-11-07/findings.json": "449ab0c9fc33060b54310c622684287525c5508204a47e7aacda1e44dc77b037", + "evidence/review-png-memory-2026-11-07/lint-archive.txt": "4d6c5ac9c907f1066911fd027b328c8d9038ef46ded69c392c54d9f8d27d4865", "evidence/review-png-memory-2026-11-07/lint-implementation.txt": "4d6c5ac9c907f1066911fd027b328c8d9038ef46ded69c392c54d9f8d27d4865", "evidence/review-png-memory-2026-11-07/offline-tests.txt": "9efe9e43fc7e9d7a2bde18e3d54efdeeb2387a1081457ef8b2615451f2583fe9", + "evidence/review-png-memory-2026-11-07/openspec-after-archive.txt": "b185f34cf979a6739249722b3df8000dcfbd0618b424dae99130e059d7cd20c7", "evidence/review-png-memory-2026-11-07/openspec-before-archive.txt": "360f59e3eb964da51f37ce7c00637e41e835670a5c657b2055a496f2f36a76f9", + "evidence/review-png-memory-2026-11-07/openspec-before-move.txt": "360f59e3eb964da51f37ce7c00637e41e835670a5c657b2055a496f2f36a76f9", "evidence/review-png-memory-2026-11-07/regression-before-command.txt": "b3a571ede4d8fe5239bb3a3f4bcb1a1d9ce257d1e580f4aac64cdcb178cc41be", "evidence/review-png-memory-2026-11-07/regression-before.txt": "02649ec20f6bbd4ec299d457f704d3c1473eda82b6da7b9808a733fdce947123", + "evidence/review-png-memory-2026-11-07/specs-sync.txt": "b185f34cf979a6739249722b3df8000dcfbd0618b424dae99130e059d7cd20c7", "evidence/review-png-memory-2026-11-07/static-audit.json": "4c6b5bb3e410c6df9a21037313828cea2b0393de610b94646f27bde3c22b9cf7", "evidence/review-png-memory-2026-11-07/unchanged-rendering.json": "f5bf484467198d9cec40affd97c42cfcd0a37c40c49a20ea604ce14babc292e8", "evidence/review-png-memory-2026-11-07/validate.txt": "422aec45ba93e5567e0de199fa32116a48c970ca3b82738b40f0ed7681ef621f" diff --git a/evidence/review-png-memory-2026-11-07/lint-archive.txt b/evidence/review-png-memory-2026-11-07/lint-archive.txt new file mode 100644 index 0000000..d851918 --- /dev/null +++ b/evidence/review-png-memory-2026-11-07/lint-archive.txt @@ -0,0 +1,6 @@ +.venv/bin/ruff check src student-tests scripts/capture_evidence.py alembic scripts/scaling.py tools scripts/probe.py scripts/limits.py scripts/lab4_scenarios.py scripts/lab4_seed.py scripts/upload_memory.py scripts/reconcile_check.py scripts/reconcile_track.py scripts/make_images.py scripts/pipeline_suite.py scripts/pipeline_evidence.py +All checks passed! +.venv/bin/ruff format --check src student-tests scripts/capture_evidence.py alembic scripts/scaling.py tools scripts/probe.py scripts/limits.py scripts/lab4_scenarios.py scripts/lab4_seed.py scripts/upload_memory.py scripts/reconcile_check.py scripts/reconcile_track.py scripts/make_images.py scripts/pipeline_suite.py scripts/pipeline_evidence.py +198 files already formatted +.venv/bin/ty check src student-tests alembic +All checks passed! diff --git a/evidence/review-png-memory-2026-11-07/openspec-after-archive.txt b/evidence/review-png-memory-2026-11-07/openspec-after-archive.txt new file mode 100644 index 0000000..57b14b1 --- /dev/null +++ b/evidence/review-png-memory-2026-11-07/openspec-after-archive.txt @@ -0,0 +1,24 @@ +- Validating... +✓ spec/lab1-event-publication +✓ spec/lab1-messenger-chats +✓ spec/lab1-messenger-history +✓ spec/lab1-messenger-identity +✓ spec/lab1-service-operability +✓ spec/lab2-auth-sessions +✓ spec/lab2-dependency-failures +✓ spec/lab2-history-index +✓ spec/lab2-persistent-storage +✓ spec/lab2-session-cache +✓ spec/lab3-failover-operations +✓ spec/lab3-idempotent-messages +✓ spec/lab3-load-balancing +✓ spec/lab4-attachments +✓ spec/lab4-object-storage +✓ spec/lab4-storage-reconciler +✓ spec/lab4-upload-resilience +✓ spec/lab5-attachment-pipeline +✓ spec/lab5-image-variants +✓ spec/lab5-job-delivery +✓ spec/lab5-job-recovery +✓ spec/lab5-versioned-pipeline +Totals: 22 passed, 0 failed (22 items) diff --git a/evidence/review-png-memory-2026-11-07/openspec-before-move.txt b/evidence/review-png-memory-2026-11-07/openspec-before-move.txt new file mode 100644 index 0000000..6b536d1 --- /dev/null +++ b/evidence/review-png-memory-2026-11-07/openspec-before-move.txt @@ -0,0 +1,25 @@ +- Validating... +✓ change/fix-lab5-png-memory +✓ spec/lab1-event-publication +✓ spec/lab1-messenger-chats +✓ spec/lab1-messenger-history +✓ spec/lab1-messenger-identity +✓ spec/lab1-service-operability +✓ spec/lab2-auth-sessions +✓ spec/lab2-dependency-failures +✓ spec/lab2-history-index +✓ spec/lab2-persistent-storage +✓ spec/lab2-session-cache +✓ spec/lab3-failover-operations +✓ spec/lab3-idempotent-messages +✓ spec/lab3-load-balancing +✓ spec/lab4-attachments +✓ spec/lab4-object-storage +✓ spec/lab4-storage-reconciler +✓ spec/lab4-upload-resilience +✓ spec/lab5-attachment-pipeline +✓ spec/lab5-image-variants +✓ spec/lab5-job-delivery +✓ spec/lab5-job-recovery +✓ spec/lab5-versioned-pipeline +Totals: 23 passed, 0 failed (23 items) diff --git a/evidence/review-png-memory-2026-11-07/specs-sync.txt b/evidence/review-png-memory-2026-11-07/specs-sync.txt new file mode 100644 index 0000000..57b14b1 --- /dev/null +++ b/evidence/review-png-memory-2026-11-07/specs-sync.txt @@ -0,0 +1,24 @@ +- Validating... +✓ spec/lab1-event-publication +✓ spec/lab1-messenger-chats +✓ spec/lab1-messenger-history +✓ spec/lab1-messenger-identity +✓ spec/lab1-service-operability +✓ spec/lab2-auth-sessions +✓ spec/lab2-dependency-failures +✓ spec/lab2-history-index +✓ spec/lab2-persistent-storage +✓ spec/lab2-session-cache +✓ spec/lab3-failover-operations +✓ spec/lab3-idempotent-messages +✓ spec/lab3-load-balancing +✓ spec/lab4-attachments +✓ spec/lab4-object-storage +✓ spec/lab4-storage-reconciler +✓ spec/lab4-upload-resilience +✓ spec/lab5-attachment-pipeline +✓ spec/lab5-image-variants +✓ spec/lab5-job-delivery +✓ spec/lab5-job-recovery +✓ spec/lab5-versioned-pipeline +Totals: 22 passed, 0 failed (22 items) diff --git a/openspec/changes/fix-lab5-png-memory/.openspec.yaml b/openspec/changes/archive/2026-11-07-fix-lab5-png-memory/.openspec.yaml similarity index 58% rename from openspec/changes/fix-lab5-png-memory/.openspec.yaml rename to openspec/changes/archive/2026-11-07-fix-lab5-png-memory/.openspec.yaml index e582ee4..ce75266 100644 --- a/openspec/changes/fix-lab5-png-memory/.openspec.yaml +++ b/openspec/changes/archive/2026-11-07-fix-lab5-png-memory/.openspec.yaml @@ -1,2 +1,4 @@ schema: spec-driven created: 2026-11-07 +archived: 2026-11-07 +lab: 5 diff --git a/openspec/changes/fix-lab5-png-memory/design.md b/openspec/changes/archive/2026-11-07-fix-lab5-png-memory/design.md similarity index 100% rename from openspec/changes/fix-lab5-png-memory/design.md rename to openspec/changes/archive/2026-11-07-fix-lab5-png-memory/design.md diff --git a/openspec/changes/fix-lab5-png-memory/proposal.md b/openspec/changes/archive/2026-11-07-fix-lab5-png-memory/proposal.md similarity index 100% rename from openspec/changes/fix-lab5-png-memory/proposal.md rename to openspec/changes/archive/2026-11-07-fix-lab5-png-memory/proposal.md diff --git a/openspec/changes/fix-lab5-png-memory/specs/lab5-image-variants/spec.md b/openspec/changes/archive/2026-11-07-fix-lab5-png-memory/specs/lab5-image-variants/spec.md similarity index 100% rename from openspec/changes/fix-lab5-png-memory/specs/lab5-image-variants/spec.md rename to openspec/changes/archive/2026-11-07-fix-lab5-png-memory/specs/lab5-image-variants/spec.md diff --git a/openspec/changes/fix-lab5-png-memory/tasks.md b/openspec/changes/archive/2026-11-07-fix-lab5-png-memory/tasks.md similarity index 95% rename from openspec/changes/fix-lab5-png-memory/tasks.md rename to openspec/changes/archive/2026-11-07-fix-lab5-png-memory/tasks.md index 9557a7f..8b877e2 100644 --- a/openspec/changes/fix-lab5-png-memory/tasks.md +++ b/openspec/changes/archive/2026-11-07-fix-lab5-png-memory/tasks.md @@ -11,4 +11,4 @@ ## 3. Завершение -- [ ] 3.1 Синхронизировать спецификацию и архивировать change; проверить чистоту нормативных файлов и сделать английские коммиты после make lint. +- [x] 3.1 Синхронизировать спецификацию и архивировать change; проверить чистоту нормативных файлов и сделать английские коммиты после make lint. diff --git a/openspec/specs/lab5-image-variants/spec.md b/openspec/specs/lab5-image-variants/spec.md index bb254bf..8f15a11 100644 --- a/openspec/specs/lab5-image-variants/spec.md +++ b/openspec/specs/lab5-image-variants/spec.md @@ -51,6 +51,11 @@ Worker SHALL ограничивать обработку одного задан - **WHEN** со штатными пределами загружен PNG 8000×5000 - **THEN** вложение становится `ready` с тремя вариантами, пик памяти контейнера worker ниже его предела +#### Scenario: Прозрачный PNG на пределе пикселей + +- **WHEN** последовательно обработаны PNG 8000×5000 grayscale 2/4/16 и RGB16 с tRNS при штатных 448 MiB адресного пространства рендера и 30 с на задание, затем запрошена версия pipeline 2 +- **THEN** каждый upload отвечает `202 queued`, обе версии становятся `ready` с тремя вариантами и неизменным оригиналом; прозрачные области белые, соседний непрозрачный цвет сохраняется, worker остаётся работоспособным и обрабатывает следующее обычное задание + #### Scenario: Пиксели сверх предела по заголовку - **WHEN** worker получает задание на оригинал, у которого по заголовку больше `MAX_IMAGE_PIXELS` пикселей