forked from mtusi2026/mtusi2026lab3
FastAPI rejects a missing Idempotency-Key, extra fields and wrong types with 400 before the handler runs, so an outsider gets the same 400 for an existing and a missing chat; only a bad text, checked by the domain, makes the handler look up membership and answer 404. The new test pins that order so it is a recorded rule rather than an accident. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V1d3RLHNBBMA6UqBLLJv27
101 lines
4.0 KiB
Python
101 lines
4.0 KiB
Python
from uuid import uuid4
|
|
|
|
from httpx import AsyncClient
|
|
|
|
from conftest import actor, keyed, make_chat, register
|
|
|
|
|
|
async def test_outsider_gets_404_on_chat(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
bob = await register(client, "bob")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice, bob)
|
|
response = await client.get(f"/api/v1/chats/{chat['id']}", headers=actor(eve))
|
|
assert response.status_code == 404
|
|
assert response.json()["error"]["code"] == "not_found"
|
|
|
|
|
|
async def test_unknown_chat_is_indistinguishable_from_foreign(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
foreign = await client.get(f"/api/v1/chats/{chat['id']}", headers=actor(eve))
|
|
missing = await client.get(f"/api/v1/chats/{uuid4()}", headers=actor(eve))
|
|
assert foreign.status_code == missing.status_code == 404
|
|
assert foreign.json()["error"]["code"] == missing.json()["error"]["code"]
|
|
assert foreign.json()["error"]["message"] == missing.json()["error"]["message"]
|
|
|
|
|
|
async def test_outsider_cannot_write(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
json={"text": "чужое"},
|
|
headers=keyed(eve),
|
|
)
|
|
assert response.status_code == 404
|
|
history = await client.get(f"/api/v1/chats/{chat['id']}/messages", headers=actor(alice))
|
|
assert history.json()["items"] == []
|
|
|
|
|
|
async def test_outsider_cannot_read_history(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.get(f"/api/v1/chats/{chat['id']}/messages", headers=actor(eve))
|
|
assert response.status_code == 404
|
|
|
|
|
|
async def test_access_checked_before_body(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
response = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
json={"text": ""},
|
|
headers=keyed(eve),
|
|
)
|
|
assert response.status_code == 404
|
|
|
|
|
|
async def test_chat_list_hides_foreign_chats(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
bob = await register(client, "bob")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice, bob)
|
|
for member in (alice, bob):
|
|
listed = await client.get("/api/v1/chats?limit=100", headers=actor(member))
|
|
assert any(item["id"] == chat["id"] for item in listed.json()["items"])
|
|
hidden = await client.get("/api/v1/chats?limit=100", headers=actor(eve))
|
|
assert hidden.json()["items"] == []
|
|
|
|
|
|
async def test_403_is_never_used(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
paths = [
|
|
f"/api/v1/chats/{chat['id']}",
|
|
f"/api/v1/chats/{chat['id']}/messages",
|
|
]
|
|
for path in paths:
|
|
assert (await client.get(path, headers=actor(eve))).status_code != 403
|
|
|
|
|
|
async def test_request_shape_is_checked_before_access(client: AsyncClient) -> None:
|
|
alice = await register(client, "alice")
|
|
eve = await register(client, "eve")
|
|
chat = await make_chat(client, alice)
|
|
for chat_id in (chat["id"], uuid4()):
|
|
path = f"/api/v1/chats/{chat_id}/messages"
|
|
unkeyed = await client.post(path, json={"text": "чужое"}, headers=actor(eve))
|
|
extra = await client.post(path, json={"text": "x", "a": 1}, headers=keyed(eve))
|
|
assert unkeyed.status_code == extra.status_code == 400
|
|
assert unkeyed.json()["error"]["code"] == extra.json()["error"]["code"] == "invalid_request"
|
|
blank = await client.post(
|
|
f"/api/v1/chats/{chat['id']}/messages", json={"text": " "}, headers=keyed(eve)
|
|
)
|
|
assert blank.status_code == 404
|