Author SHA1 Message Date
Kalibr c3c5d0f036 Обновить REPORT.md 2026-10-09 15:15:58 +03:00
11 changed files with 102 additions and 103 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
- Автор, группа: Бабиченко Максим, БВТ2303 - Автор, группа: Бабиченко Максим, БВТ2303
- Целевая оценка; 4 - Целевая оценка; 4
- Commit/PR: https://gitea.privcloud.tech/mtusi2026/mtusi2026lab2/pulls/26 - Commit/PR: https://gitea.privcloud.tech/mtusi2026/mtusi2026lab2/pulls/29
- Использованные источники, библиотеки и помощь ИИ: FastAPI, Uvicorn, Pydantic, psycopg 3 и psycopg-pool, argon2-cffi, redis-py (точные версии в requirements.txt); образы python:3.11.13-slim, postgres:17.11-alpine, redis:7.4.11-alpine; документация PostgreSQL (транзакции, индексы, EXPLAIN), документация Redis (persistence, AOF), RFC 7617 (Basic). Помощь ИИ: использовался как консультант по git и PowerShell, для разбора ошибок Docker (монтирование секретов, пароль PostgreSQL в старом volume) - Использованные источники, библиотеки и помощь ИИ: FastAPI, Uvicorn, Pydantic, psycopg 3 и psycopg-pool, argon2-cffi, redis-py (точные версии в requirements.txt); образы python:3.11.13-slim, postgres:17.11-alpine, redis:7.4.11-alpine; документация PostgreSQL (транзакции, индексы, EXPLAIN), документация Redis (persistence, AOF), RFC 7617 (Basic). Помощь ИИ: использовался как консультант по git и PowerShell, для разбора ошибок Docker (монтирование секретов, пароль PostgreSQL в старом volume)
## Запуск из чистого clone ## Запуск из чистого clone
+21 -33
View File
@@ -26,6 +26,7 @@ pool = ConnectionPool(
"options": f"-c statement_timeout={settings.DB_STATEMENT_TIMEOUT_MS}" "options": f"-c statement_timeout={settings.DB_STATEMENT_TIMEOUT_MS}"
" -c idle_in_transaction_session_timeout=10000 -c TimeZone=UTC", " -c idle_in_transaction_session_timeout=10000 -c TimeZone=UTC",
}, },
check=ConnectionPool.check_connection, check=ConnectionPool.check_connection,
open=False, open=False,
) )
@@ -33,29 +34,16 @@ pool = ConnectionPool(
@contextmanager @contextmanager
def connection(wait_seconds: float | None = None): def connection(wait_seconds: float | None = None):
"""Соединение из пула. В конце блока COMMIT, при исключении ROLLBACK.
Если база недоступна, клиент получает 503 без подробностей.
"""
try: try:
with pool.connection(timeout=wait_seconds) as conn: with pool.connection(timeout=wait_seconds) as conn:
yield conn yield conn
except (psycopg.OperationalError, PoolTimeout) as exc: except (psycopg.OperationalError, PoolTimeout) as exc:
log.warning("PostgreSQL is unavailable: %s", type(exc).__name__) log.warning("PostgreSQL is unavailable: %s", type(exc).__name__)
raise unavailable() from None raise unavailable() from None
except psycopg.DataError as exc:
log.warning("PostgreSQL rejected a value: %s", type(exc).__name__)
raise bad_request("Invalid request data") from None
TEXT_FIELDS = ("display_name", "title", "text")
def to_db(value: str) -> bytes:
return value.encode("utf-8")
def from_db(row: dict | None) -> dict | None:
"""Строка из БД -> dict для API: байты текстовых полей обратно в str."""
if row is None:
return None
return {key: bytes(value).decode("utf-8") if key in TEXT_FIELDS else value for key, value in row.items()}
def ping() -> None: def ping() -> None:
@@ -63,6 +51,7 @@ def ping() -> None:
conn.execute("SELECT 1") conn.execute("SELECT 1")
MIGRATIONS_LOCK = 20260202 MIGRATIONS_LOCK = 20260202
@@ -111,25 +100,26 @@ USER_COLUMNS = "id, username, display_name, created_at"
def create_user(username: str, display_name: str, password_hash: str) -> dict: def create_user(username: str, display_name: str, password_hash: str) -> dict:
try: try:
with connection() as conn: with connection() as conn:
return from_db(conn.execute( return conn.execute(
f"""INSERT INTO users (id, username, display_name, password_hash) f"""INSERT INTO users (id, username, display_name, password_hash)
VALUES (%s, %s, %s, %s) RETURNING {USER_COLUMNS}""", VALUES (%s, %s, %s, %s) RETURNING {USER_COLUMNS}""",
(uuid4(), username, to_db(display_name), password_hash), (uuid4(), username, display_name, password_hash),
).fetchone()) ).fetchone()
except pg_errors.UniqueViolation: except pg_errors.UniqueViolation:
raise conflict("Username already exists") from None raise conflict("Username already exists") from None
def get_user(user_id: UUID) -> dict | None: def get_user(user_id: UUID) -> dict | None:
with connection() as conn: with connection() as conn:
return from_db(conn.execute(f"SELECT {USER_COLUMNS} FROM users WHERE id = %s", (user_id,)).fetchone()) return conn.execute(f"SELECT {USER_COLUMNS} FROM users WHERE id = %s", (user_id,)).fetchone()
def get_user_with_password(username: str) -> dict | None: def get_user_with_password(username: str) -> dict | None:
with connection() as conn: with connection() as conn:
return from_db(conn.execute( return conn.execute(
f"SELECT {USER_COLUMNS}, password_hash FROM users WHERE username = %s", (username,) f"SELECT {USER_COLUMNS}, password_hash FROM users WHERE username = %s", (username,)
).fetchone()) ).fetchone()
CHAT_COLUMNS = """c.id, c.title, c.created_at, CHAT_COLUMNS = """c.id, c.title, c.created_at,
@@ -144,7 +134,7 @@ def create_chat(title: str, member_ids: list[UUID]) -> dict:
with conn.transaction(): with conn.transaction():
row = conn.execute( row = conn.execute(
"INSERT INTO chats (id, title) VALUES (%s, %s) RETURNING id, title, created_at", "INSERT INTO chats (id, title) VALUES (%s, %s) RETURNING id, title, created_at",
(chat_id, to_db(title)), (chat_id, title),
).fetchone() ).fetchone()
with conn.cursor() as cur: with conn.cursor() as cur:
cur.executemany( cur.executemany(
@@ -153,7 +143,7 @@ def create_chat(title: str, member_ids: list[UUID]) -> dict:
) )
except pg_errors.ForeignKeyViolation: except pg_errors.ForeignKeyViolation:
raise bad_request("Unknown member") from None raise bad_request("Unknown member") from None
return {**from_db(row), "member_ids": members} return {**row, "member_ids": members}
def get_chat(chat_id: UUID, user_id: UUID) -> dict: def get_chat(chat_id: UUID, user_id: UUID) -> dict:
@@ -166,7 +156,7 @@ def get_chat(chat_id: UUID, user_id: UUID) -> dict:
).fetchone() ).fetchone()
if chat is None: if chat is None:
raise not_found("Chat not found") raise not_found("Chat not found")
return from_db(chat) return chat
def list_chats(user_id: UUID, after: tuple[datetime, UUID] | None, limit: int) -> list[dict]: def list_chats(user_id: UUID, after: tuple[datetime, UUID] | None, limit: int) -> list[dict]:
@@ -176,7 +166,7 @@ def list_chats(user_id: UUID, after: tuple[datetime, UUID] | None, limit: int) -
where = "WHERE (c.created_at, c.id) > (%s, %s)" where = "WHERE (c.created_at, c.id) > (%s, %s)"
params += list(after) params += list(after)
with connection() as conn: with connection() as conn:
rows = conn.execute( return conn.execute(
f"""SELECT {CHAT_COLUMNS} FROM chats c f"""SELECT {CHAT_COLUMNS} FROM chats c
JOIN chat_members me ON me.chat_id = c.id AND me.user_id = %s JOIN chat_members me ON me.chat_id = c.id AND me.user_id = %s
{where} {where}
@@ -184,7 +174,6 @@ def list_chats(user_id: UUID, after: tuple[datetime, UUID] | None, limit: int) -
LIMIT %s""", LIMIT %s""",
(*params, limit + 1), (*params, limit + 1),
).fetchall() ).fetchall()
return [from_db(row) for row in rows]
@@ -194,11 +183,11 @@ MESSAGE_COLUMNS = "id, chat_id, sender_id, text, created_at"
def add_message(chat_id: UUID, sender_id: UUID, text: str) -> dict: def add_message(chat_id: UUID, sender_id: UUID, text: str) -> dict:
try: try:
with connection() as conn: with connection() as conn:
return from_db(conn.execute( return conn.execute(
f"""INSERT INTO messages (id, chat_id, sender_id, text) f"""INSERT INTO messages (id, chat_id, sender_id, text)
VALUES (%s, %s, %s, %s) RETURNING {MESSAGE_COLUMNS}""", VALUES (%s, %s, %s, %s) RETURNING {MESSAGE_COLUMNS}""",
(uuid4(), chat_id, sender_id, to_db(text)), (uuid4(), chat_id, sender_id, text),
).fetchone()) ).fetchone()
except pg_errors.ForeignKeyViolation: except pg_errors.ForeignKeyViolation:
raise not_found("Chat not found") from None raise not_found("Chat not found") from None
@@ -215,11 +204,10 @@ def list_messages(chat_id: UUID, user_id: UUID, after: tuple[datetime, UUID] | N
).fetchone() ).fetchone()
if member is None: if member is None:
raise not_found("Chat not found") raise not_found("Chat not found")
rows = conn.execute( return conn.execute(
f"""SELECT {MESSAGE_COLUMNS} FROM messages f"""SELECT {MESSAGE_COLUMNS} FROM messages
WHERE {where} WHERE {where}
ORDER BY created_at, id ORDER BY created_at, id
LIMIT %s""", LIMIT %s""",
(*params, limit + 1), (*params, limit + 1),
).fetchall() ).fetchall()
return [from_db(row) for row in rows]
BIN
View File
Binary file not shown.
+29 -29
View File
@@ -1,7 +1,7 @@
=== Data volume === Data volume
messages_total | messages_in_big_chat messages_total | messages_in_big_chat
----------------+---------------------- ----------------+----------------------
20250 | 15000 20116 | 15000
=== History index === History index
@@ -13,58 +13,58 @@
=== 1. First page: limit=50, the app asks for 51 rows to know if there is a next page === 1. First page: limit=50, the app asks for 51 rows to know if there is a next page
QUERY PLAN QUERY PLAN
------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------
Limit (actual time=0.005..0.011 rows=51 loops=1) Limit (actual time=0.007..0.012 rows=51 loops=1)
Buffers: shared hit=4 Buffers: shared hit=4
-> Index Scan using messages_history on messages (actual time=0.004..0.008 rows=51 loops=1) -> Index Scan using messages_history on messages (actual time=0.007..0.009 rows=51 loops=1)
Index Cond: (chat_id = 'edccb516-a15c-427e-a8d3-9b1b2d9ea77c'::uuid) Index Cond: (chat_id = '6a75871f-4837-4b3c-b7c8-1c36de87da98'::uuid)
Buffers: shared hit=4 Buffers: shared hit=4
Planning: Planning:
Buffers: shared hit=6 Buffers: shared hit=8
Planning Time: 0.055 ms Planning Time: 0.155 ms
Execution Time: 0.020 ms Execution Time: 0.028 ms
=== 2. Page after the 10000th message by keyset cursor (this is what the app does) === 2. Page after the 10000th message by keyset cursor (this is what the app does)
QUERY PLAN QUERY PLAN
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Limit (actual time=0.006..0.011 rows=51 loops=1) Limit (actual time=0.006..0.012 rows=51 loops=1)
Buffers: shared hit=4 Buffers: shared hit=6
-> Index Scan using messages_history on messages (actual time=0.006..0.008 rows=51 loops=1) -> Index Scan using messages_history on messages (actual time=0.006..0.010 rows=51 loops=1)
Index Cond: ((chat_id = 'edccb516-a15c-427e-a8d3-9b1b2d9ea77c'::uuid) AND (ROW(created_at, id) > ROW('2026-09-01 02:46:40+00'::timestamp with time zone, '3b67880a-c02c-48ac-aec2-1a0331e99fee'::uuid))) Index Cond: ((chat_id = '6a75871f-4837-4b3c-b7c8-1c36de87da98'::uuid) AND (ROW(created_at, id) > ROW('2026-09-01 02:46:40+00'::timestamp with time zone, 'd867a7e3-2b56-475a-81c9-19729e8336c2'::uuid)))
Buffers: shared hit=4 Buffers: shared hit=6
Planning Time: 0.038 ms Planning Time: 0.038 ms
Execution Time: 0.028 ms Execution Time: 0.031 ms
=== 3. The same page with OFFSET 10000 (the app does NOT do this) === 3. The same page with OFFSET 10000 (the app does NOT do this)
QUERY PLAN QUERY PLAN
--------------------------------------------------------------------------------------------------- ---------------------------------------------------------------------------------------------------
Limit (actual time=0.747..0.752 rows=51 loops=1) Limit (actual time=0.716..0.721 rows=51 loops=1)
Buffers: shared hit=199 Buffers: shared hit=257
-> Index Scan using messages_history on messages (actual time=0.006..0.566 rows=10051 loops=1) -> Index Scan using messages_history on messages (actual time=0.008..0.521 rows=10051 loops=1)
Index Cond: (chat_id = 'edccb516-a15c-427e-a8d3-9b1b2d9ea77c'::uuid) Index Cond: (chat_id = '6a75871f-4837-4b3c-b7c8-1c36de87da98'::uuid)
Buffers: shared hit=199 Buffers: shared hit=257
Planning Time: 0.033 ms Planning Time: 0.028 ms
Execution Time: 0.765 ms Execution Time: 0.765 ms
=== 4. Query 2 without the index (index is dropped only inside this transaction) === 4. Query 2 without the index (index is dropped only inside this transaction)
QUERY PLAN QUERY PLAN
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Limit (actual time=0.895..0.898 rows=51 loops=1) Limit (actual time=0.862..0.865 rows=51 loops=1)
Buffers: shared hit=251 Buffers: shared hit=255
-> Sort (actual time=0.895..0.896 rows=51 loops=1) -> Sort (actual time=0.861..0.863 rows=51 loops=1)
Sort Key: created_at, id Sort Key: created_at, id
Sort Method: top-N heapsort Memory: 31kB Sort Method: top-N heapsort Memory: 31kB
Buffers: shared hit=251 Buffers: shared hit=255
-> Seq Scan on messages (actual time=0.320..0.719 rows=5000 loops=1) -> Seq Scan on messages (actual time=0.289..0.686 rows=5000 loops=1)
Filter: ((chat_id = 'edccb516-a15c-427e-a8d3-9b1b2d9ea77c'::uuid) AND (ROW(created_at, id) > ROW('2026-09-01 02:46:40+00'::timestamp with time zone, '3b67880a-c02c-48ac-aec2-1a0331e99fee'::uuid))) Filter: ((chat_id = '6a75871f-4837-4b3c-b7c8-1c36de87da98'::uuid) AND (ROW(created_at, id) > ROW('2026-09-01 02:46:40+00'::timestamp with time zone, 'd867a7e3-2b56-475a-81c9-19729e8336c2'::uuid)))
Rows Removed by Filter: 15250 Rows Removed by Filter: 15116
Buffers: shared hit=251 Buffers: shared hit=255
Planning: Planning:
Buffers: shared hit=4 Buffers: shared hit=4
Planning Time: 0.043 ms Planning Time: 0.051 ms
Execution Time: 0.912 ms Execution Time: 0.884 ms
=== ROLLBACK: test data removed, index is back === ROLLBACK: test data removed, index is back
Binary file not shown.
Binary file not shown.
+12 -4
View File
@@ -1,8 +1,16 @@
"""Мессенджер, lab2: HTTP API по contracts/openapi.json.
Что изменилось с lab1:
- данные (users, chats, messages) теперь в PostgreSQL, а не в словарях: см. db.py;
- регистрация принимает password, вход — POST /auth/sessions с Basic, выход — DELETE;
- текущий пользователь определяется только по Bearer-токену (сессии в Redis, см. auth.py),
заголовок X-User-Id больше ничего не значит.
Модели, формат ошибок, X-Request-Id и курсоры остались из lab1.
"""
import base64 import base64
import binascii import binascii
import json import json
import logging import logging
import re
import time import time
import uuid import uuid
from contextlib import asynccontextmanager from contextlib import asynccontextmanager
@@ -41,8 +49,6 @@ async def lifespan(app: FastAPI):
app = FastAPI(lifespan=lifespan) app = FastAPI(lifespan=lifespan)
USERNAME_RE = re.compile(r"[a-z0-9_]{3,32}")
class CreateUser(BaseModel): class CreateUser(BaseModel):
model_config = ConfigDict(extra="forbid") model_config = ConfigDict(extra="forbid")
@@ -291,6 +297,7 @@ def page_after(cursor: str | None, *, chat_id: UUID | None = None, user_id: UUID
return created_at, object_id return created_at, object_id
@app.get("/health/live") @app.get("/health/live")
def health_live(): def health_live():
return {"status": "ok"} return {"status": "ok"}
@@ -303,6 +310,7 @@ def health_ready():
return {"status": "ok"} return {"status": "ok"}
@app.post("/api/v1/users", response_model=User, status_code=201) @app.post("/api/v1/users", response_model=User, status_code=201)
def create_user(user_data: CreateUser): def create_user(user_data: CreateUser):
password_hash = auth.hash_password(user_data.password) # сам пароль нигде не сохраняется password_hash = auth.hash_password(user_data.password) # сам пароль нигде не сохраняется
@@ -320,7 +328,7 @@ def create_session(
username, password = credentials username, password = credentials
found = None found = None
if USERNAME_RE.fullmatch(username) and len(password) <= auth.PASSWORD_MAX_LENGTH: if len(password) <= auth.PASSWORD_MAX_LENGTH:
found = db.get_user_with_password(username) found = db.get_user_with_password(username)
if not auth.password_matches(found["password_hash"] if found else None, password): if not auth.password_matches(found["password_hash"] if found else None, password):
raise auth.login_failed() raise auth.login_failed()
-11
View File
@@ -1,11 +0,0 @@
ALTER TABLE users DROP CONSTRAINT users_display_name_check;
ALTER TABLE chats DROP CONSTRAINT chats_title_check;
ALTER TABLE messages DROP CONSTRAINT messages_text_check;
ALTER TABLE users ALTER COLUMN display_name TYPE bytea USING convert_to(display_name, 'UTF8');
ALTER TABLE chats ALTER COLUMN title TYPE bytea USING convert_to(title, 'UTF8');
ALTER TABLE messages ALTER COLUMN text TYPE bytea USING convert_to(text, 'UTF8');
ALTER TABLE users ADD CONSTRAINT users_display_name_check CHECK (octet_length(display_name) BETWEEN 1 AND 400);
ALTER TABLE chats ADD CONSTRAINT chats_title_check CHECK (octet_length(title) BETWEEN 1 AND 400);
ALTER TABLE messages ADD CONSTRAINT messages_text_check CHECK (octet_length(text) BETWEEN 1 AND 16000);
+11 -4
View File
@@ -1,24 +1,31 @@
-- Обоснование индекса истории messages_history (migrations/001_init.sql).
-- Запуск: python student-tests/explain.py (результат -> evidence/explain-history.txt)
--
-- Всё в одной транзакции, в конце ROLLBACK: тестовые данные не остаются в базе,
-- скрипт можно запускать сколько угодно раз.
\pset footer off \pset footer off
BEGIN; BEGIN;
-- Тестовые данные: один большой чат на 15 000 сообщений и 50 маленьких по 100,
-- всего 20 000 сообщений. Чужие сообщения в таблице есть, как в настоящей базе.
CREATE TEMP TABLE seed_chats AS CREATE TEMP TABLE seed_chats AS
SELECT gen_random_uuid() AS id, n, CASE WHEN n = 0 THEN 15000 ELSE 100 END AS size SELECT gen_random_uuid() AS id, n, CASE WHEN n = 0 THEN 15000 ELSE 100 END AS size
FROM generate_series(0, 50) AS n; FROM generate_series(0, 50) AS n;
CREATE TEMP TABLE seed_user AS SELECT gen_random_uuid() AS id; CREATE TEMP TABLE seed_user AS SELECT gen_random_uuid() AS id;
INSERT INTO users (id, username, display_name, password_hash) INSERT INTO users (id, username, display_name, password_hash)
SELECT id, 'explain_' || substr(md5(random()::text), 1, 10), convert_to('Explain', 'UTF8'), 'not-a-real-hash' SELECT id, 'explain_' || substr(md5(random()::text), 1, 10), 'Explain', 'not-a-real-hash' FROM seed_user;
FROM seed_user; INSERT INTO chats (id, title) SELECT id, 'explain ' || n FROM seed_chats;
INSERT INTO chats (id, title) SELECT id, convert_to('explain ' || n, 'UTF8') FROM seed_chats;
INSERT INTO chat_members (chat_id, user_id) SELECT c.id, u.id FROM seed_chats c, seed_user u; INSERT INTO chat_members (chat_id, user_id) SELECT c.id, u.id FROM seed_chats c, seed_user u;
INSERT INTO messages (id, chat_id, sender_id, text, created_at) INSERT INTO messages (id, chat_id, sender_id, text, created_at)
SELECT gen_random_uuid(), c.id, u.id, convert_to('message ' || g, 'UTF8'), SELECT gen_random_uuid(), c.id, u.id, 'message ' || g,
timestamptz '2026-09-01 00:00:00+00' + g * interval '1 second' timestamptz '2026-09-01 00:00:00+00' + g * interval '1 second'
FROM seed_chats c, seed_user u, generate_series(1, c.size) AS g; FROM seed_chats c, seed_user u, generate_series(1, c.size) AS g;
ANALYZE messages; ANALYZE messages;
SELECT id AS big_chat FROM seed_chats WHERE n = 0 \gset SELECT id AS big_chat FROM seed_chats WHERE n = 0 \gset
-- Курсор глубоко в истории: ключ (created_at, id) 10 000-го сообщения большого чата.
SELECT created_at AS cursor_time, id AS cursor_id FROM messages SELECT created_at AS cursor_time, id AS cursor_id FROM messages
WHERE chat_id = :'big_chat' ORDER BY created_at, id OFFSET 9999 LIMIT 1 \gset WHERE chat_id = :'big_chat' ORDER BY created_at, id OFFSET 9999 LIMIT 1 \gset
+12 -18
View File
@@ -1,3 +1,10 @@
"""Собственные тесты API (lab1 + lab2). Запуск одной командой при запущенном стенде:
python student-tests/test_api.py
Тесты lab1 переведены с X-User-Id на пароль и Bearer-токен. Добавлены тесты lab2:
вход по Basic, неверный пароль, logout, Bearer на всех защищённых запросах.
"""
import base64 import base64
import datetime as dt import datetime as dt
import uuid import uuid
@@ -9,6 +16,7 @@ def parse_time(value):
return dt.datetime.fromisoformat(value.replace("Z", "+00:00")) return dt.datetime.fromisoformat(value.replace("Z", "+00:00"))
# ---------- lab1 (перенесены, теперь с токенами) ----------
def test_duplicate_username(): def test_duplicate_username():
body = {"username": "dup_" + uuid.uuid4().hex[:10], "display_name": "First user", "password": PASSWORD} body = {"username": "dup_" + uuid.uuid4().hex[:10], "display_name": "First user", "password": PASSWORD}
@@ -71,6 +79,7 @@ def test_pagination():
for i in range(3): for i in range(3):
send(alice, other["id"], f"Other {i}") send(alice, other["id"], f"Other {i}")
first = call("GET", f"/api/v1/chats/{other['id']}/messages?limit=1", token=alice["token"]).json first = call("GET", f"/api/v1/chats/{other['id']}/messages?limit=1", token=alice["token"]).json
# Курсор от другого чата и испорченный курсор — 400.
call("GET", f"/api/v1/chats/{chat['id']}/messages?cursor={first['next_cursor']}", 400, token=alice["token"]) call("GET", f"/api/v1/chats/{chat['id']}/messages?cursor={first['next_cursor']}", 400, token=alice["token"])
call("GET", f"/api/v1/chats/{chat['id']}/messages?cursor=broken", 400, token=alice["token"]) call("GET", f"/api/v1/chats/{chat['id']}/messages?cursor=broken", 400, token=alice["token"])
print("PASS: pagination works across multiple pages, foreign cursor returns 400") print("PASS: pagination works across multiple pages, foreign cursor returns 400")
@@ -101,23 +110,7 @@ def test_unicode():
print("PASS: unicode text is stored as is") print("PASS: unicode text is stored as is")
def test_nul_character_is_stored(): # ---------- lab2: пароль, вход, Bearer, logout ----------
name, title, text = "A\u0000B", "Chat\u0000title", "hello\u0000world"
body = {"username": "nul_" + uuid.uuid4().hex[:10], "display_name": name, "password": "pass\u0000word-123"}
user = call("POST", "/api/v1/users", 201, body=body).json
check(user["display_name"] == name, "display_name with U+0000 changed")
token = login(body["username"], body["password"]).json["token"]
check(call("GET", "/api/v1/users/me", token=token).json["display_name"] == name, "display_name changed on read")
chat = call("POST", "/api/v1/chats", 201, token=token, body={"title": title, "member_ids": [user["id"]]}).json
check(chat["title"] == title, "title with U+0000 changed")
check(call("GET", f"/api/v1/chats/{chat['id']}", token=token).json["title"] == title, "title changed on read")
sent = call("POST", f"/api/v1/chats/{chat['id']}/messages", 201, token=token, body={"text": text}).json
history = call("GET", f"/api/v1/chats/{chat['id']}/messages", token=token).json["items"]
check(sent["text"] == text and history[-1]["text"] == text, "text with U+0000 changed")
login("nul\u0000user", PASSWORD, expected=401)
print("PASS: strings with U+0000 are stored and returned as is")
def test_user_has_no_password(): def test_user_has_no_password():
body = {"username": "np_" + uuid.uuid4().hex[:10], "display_name": "No password", "password": PASSWORD} body = {"username": "np_" + uuid.uuid4().hex[:10], "display_name": "No password", "password": PASSWORD}
@@ -162,6 +155,7 @@ def test_wrong_password():
wrong = login(user["username"], "Wrong-password-000", expected=401) wrong = login(user["username"], "Wrong-password-000", expected=401)
unknown = login("nobody_" + uuid.uuid4().hex[:8], PASSWORD, expected=401) unknown = login("nobody_" + uuid.uuid4().hex[:8], PASSWORD, expected=401)
check(wrong.headers["www-authenticate"].lower().startswith("basic"), "login 401 must ask for Basic") check(wrong.headers["www-authenticate"].lower().startswith("basic"), "login 401 must ask for Basic")
# Одинаковый ответ: по нему нельзя узнать, существует ли такой username.
check(wrong.json["error"]["message"] == unknown.json["error"]["message"], "different answers leak usernames") check(wrong.json["error"]["message"] == unknown.json["error"]["message"], "different answers leak usernames")
print("PASS: wrong password and unknown user both return the same 401") print("PASS: wrong password and unknown user both return the same 401")
@@ -202,6 +196,7 @@ def test_x_user_id_ignored():
def test_auth_before_body(): def test_auth_before_body():
alice = new_user("alice") alice = new_user("alice")
chat = new_chat(alice) chat = new_chat(alice)
# Без токена всегда 401, даже если тело неверное или чат чужой: сначала «кто ты».
call("POST", f"/api/v1/chats/{chat['id']}/messages", 401, raw=b"not json") call("POST", f"/api/v1/chats/{chat['id']}/messages", 401, raw=b"not json")
call("GET", f"/api/v1/chats/{uuid.uuid4()}", 401) call("GET", f"/api/v1/chats/{uuid.uuid4()}", 401)
print("PASS: 401 comes before 400 and 404") print("PASS: 401 comes before 400 and 404")
@@ -230,7 +225,6 @@ if __name__ == "__main__":
test_pagination, test_pagination,
test_chat_list_pagination, test_chat_list_pagination,
test_unicode, test_unicode,
test_nul_character_is_stored,
test_user_has_no_password, test_user_has_no_password,
test_password_rules, test_password_rules,
test_login_gives_token, test_login_gives_token,
+14 -1
View File
@@ -1,3 +1,14 @@
"""Проверки на уровне базы данных. Запуск при запущенном стенде:
python student-tests/test_db.py
SQL выполняется в контейнере postgres через `docker compose exec postgres psql`.
1. Откат составной операции: чат с несуществующим участником -> 400, и в базе
не остаётся ни чата, ни участников, хотя строка чата успела вставиться.
2. База сама не даёт записать сообщение от не-участника (внешний ключ).
3. Пароль хранится как хеш Argon2id, а не как текст или быстрый хеш.
4. Миграции: после перезапуска API ничего не применяется повторно.
"""
import time import time
import uuid import uuid
@@ -15,12 +26,14 @@ def test_create_chat_rolls_back():
title = "rollback-" + uuid.uuid4().hex[:8] title = "rollback-" + uuid.uuid4().hex[:8]
inserted_before = int(sql_value("SELECT n_tup_ins FROM pg_stat_user_tables WHERE relname = 'chats'")) inserted_before = int(sql_value("SELECT n_tup_ins FROM pg_stat_user_tables WHERE relname = 'chats'"))
# Второй участник не существует: INSERT чата пройдёт, INSERT участника упадёт на внешнем ключе.
call("POST", "/api/v1/chats", 400, token=alice["token"], call("POST", "/api/v1/chats", 400, token=alice["token"],
body={"title": title, "member_ids": [alice["id"], str(uuid.uuid4())]}) body={"title": title, "member_ids": [alice["id"], str(uuid.uuid4())]})
left = sql_value(f"SELECT count(*) FROM chats WHERE title = '{title}'") left = sql_value(f"SELECT count(*) FROM chats WHERE title = '{title}'")
orphans = sql_value("SELECT count(*) FROM chats c WHERE NOT EXISTS " orphans = sql_value("SELECT count(*) FROM chats c WHERE NOT EXISTS "
"(SELECT 1 FROM chat_members m WHERE m.chat_id = c.id)") "(SELECT 1 FROM chat_members m WHERE m.chat_id = c.id)")
# Статистика PostgreSQL считает и отменённые вставки; она обновляется с задержкой до ~1 с.
inserted_after = inserted_before inserted_after = inserted_before
deadline = time.monotonic() + 15 deadline = time.monotonic() + 15
while inserted_after == inserted_before and time.monotonic() < deadline: while inserted_after == inserted_before and time.monotonic() < deadline:
@@ -35,7 +48,7 @@ def test_create_chat_rolls_back():
def test_message_needs_membership_in_db(): def test_message_needs_membership_in_db():
code, _, error = psql("INSERT INTO messages (id, chat_id, sender_id, text) " code, _, error = psql("INSERT INTO messages (id, chat_id, sender_id, text) "
f"VALUES ('{uuid.uuid4()}', '{uuid.uuid4()}', '{uuid.uuid4()}', convert_to('direct insert', 'UTF8'))") f"VALUES ('{uuid.uuid4()}', '{uuid.uuid4()}', '{uuid.uuid4()}', 'direct insert')")
print(f"direct INSERT of a message from a non-member -> exit code {code}: {error.splitlines()[0] if error else ''}") print(f"direct INSERT of a message from a non-member -> exit code {code}: {error.splitlines()[0] if error else ''}")
check(code != 0 and "foreign key" in error, "database accepted a message from a non-member") check(code != 0 and "foreign key" in error, "database accepted a message from a non-member")
print("PASS: the database itself rejects a message from a non-member") print("PASS: the database itself rejects a message from a non-member")